Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(380)

Unified Diff: build/common.gypi

Issue 100066: Take 2 at turning on -Werror. I think this will work on gcc 4.2, (Closed)
Patch Set: Created 11 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: build/common.gypi
diff --git a/build/common.gypi b/build/common.gypi
index 49b030dad07a9696fe333360db56106530c01183..fccc0b0aadde7b63d1c0512520db18159c5a2fd1 100644
--- a/build/common.gypi
+++ b/build/common.gypi
@@ -180,8 +180,7 @@
'-msse2',
'-mfpmath=sse',
'-Wall',
- # TODO(sgk): when chromium_code targets are clean of warnings.
- #'-Werror',
+ '-Werror',
],
'ldflags': [
'-m32',
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698