Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(463)

Side by Side Diff: build/common.gypi

Issue 100066: Take 2 at turning on -Werror. I think this will work on gcc 4.2, (Closed)
Patch Set: Created 11 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 # Copyright (c) 2009 The Chromium Authors. All rights reserved. 1 # Copyright (c) 2009 The Chromium Authors. All rights reserved.
2 # Use of this source code is governed by a BSD-style license that can be 2 # Use of this source code is governed by a BSD-style license that can be
3 # found in the LICENSE file. 3 # found in the LICENSE file.
4 4
5 { 5 {
6 'variables': { 6 'variables': {
7 # .gyp files should set chromium_code to 1 if they build Chromium-specific 7 # .gyp files should set chromium_code to 1 if they build Chromium-specific
8 # code, as opposed to external code. This variable is used to control 8 # code, as opposed to external code. This variable is used to control
9 # such things as the set of warnings to enable, and whether warnings are 9 # such things as the set of warnings to enable, and whether warnings are
10 # treated as errors. 10 # treated as errors.
(...skipping 162 matching lines...) Expand 10 before | Expand all | Expand 10 after
173 # compiler optimized the code, since the value is always kept 173 # compiler optimized the code, since the value is always kept
174 # in its specified precision. 174 # in its specified precision.
175 'cflags': [ 175 'cflags': [
176 '-m32', 176 '-m32',
177 '-pthread', 177 '-pthread',
178 '-march=pentium4', 178 '-march=pentium4',
179 '-fno-exceptions', 179 '-fno-exceptions',
180 '-msse2', 180 '-msse2',
181 '-mfpmath=sse', 181 '-mfpmath=sse',
182 '-Wall', 182 '-Wall',
183 # TODO(sgk): when chromium_code targets are clean of warnings. 183 '-Werror',
184 #'-Werror',
185 ], 184 ],
186 'ldflags': [ 185 'ldflags': [
187 '-m32', 186 '-m32',
188 '-pthread', 187 '-pthread',
189 ], 188 ],
190 'scons_variable_settings': { 189 'scons_variable_settings': {
191 'LIBPATH': ['$LIB_DIR'], 190 'LIBPATH': ['$LIB_DIR'],
192 # Linking of large files uses lots of RAM, so serialize links 191 # Linking of large files uses lots of RAM, so serialize links
193 # using the handy flock command from util-linux. 192 # using the handy flock command from util-linux.
194 'FLOCK_LINK': ['flock', '$TOP_BUILDDIR/linker.lock', '$LINK'], 193 'FLOCK_LINK': ['flock', '$TOP_BUILDDIR/linker.lock', '$LINK'],
(...skipping 234 matching lines...) Expand 10 before | Expand all | Expand 10 after
429 # settings in target dicts. SYMROOT is a special case, because many other 428 # settings in target dicts. SYMROOT is a special case, because many other
430 # Xcode variables depend on it, including variables such as 429 # Xcode variables depend on it, including variables such as
431 # PROJECT_DERIVED_FILE_DIR. When a source group corresponding to something 430 # PROJECT_DERIVED_FILE_DIR. When a source group corresponding to something
432 # like PROJECT_DERIVED_FILE_DIR is added to a project, in order for the 431 # like PROJECT_DERIVED_FILE_DIR is added to a project, in order for the
433 # files to appear (when present) in the UI as actual files and not red 432 # files to appear (when present) in the UI as actual files and not red
434 # red "missing file" proxies, the correct path to PROJECT_DERIVED_FILE_DIR, 433 # red "missing file" proxies, the correct path to PROJECT_DERIVED_FILE_DIR,
435 # and therefore SYMROOT, needs to be set at the project level. 434 # and therefore SYMROOT, needs to be set at the project level.
436 'SYMROOT': '<(DEPTH)/xcodebuild', 435 'SYMROOT': '<(DEPTH)/xcodebuild',
437 }, 436 },
438 } 437 }
OLDNEW
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698