Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(49)

Issue 100066: Take 2 at turning on -Werror. I think this will work on gcc 4.2, (Closed)

Created:
11 years, 8 months ago by tony
Modified:
9 years, 7 months ago
Reviewers:
Evan Martin
CC:
chromium-reviews_googlegroups.com
Visibility:
Public.

Description

Take 2 at turning on -Werror. I think this will work on gcc 4.2, 4.3, and 4.4. I'll watch the bots closely.

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -2 lines) Patch
M build/common.gypi View 1 chunk +1 line, -2 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
tony
11 years, 8 months ago (2009-04-27 20:54:49 UTC) #1
Evan Martin
11 years, 8 months ago (2009-04-27 21:01:33 UTC) #2
LGTM (in case it wasn't obvious you could TBR this)

Powered by Google App Engine
This is Rietveld 408576698