chrome/browser/ui/webui/plugins_ui.cc - Issue 10006028: Plugins page in BWSI session has unnecessary and misleading UI components

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/webui/plugins_ui.cc

Issue 10006028: Plugins page in BWSI session has unnecessary and misleading UI components (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Third review iteration Created 8 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/resources/plugins.html ('K') | « chrome/browser/ui/webui/options2/chromeos/core_chromeos_options_handler2.cc ('k') | chrome/chrome_browser.gypi » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/webui/plugins_ui.cc

diff --git a/chrome/browser/ui/webui/plugins_ui.cc b/chrome/browser/ui/webui/plugins_ui.cc

index 16cfa42c4ef4b6394cccb087cb08b06813dba127..cc4b69cfdc6a518ed4e162a43bb69da4f4e3b06e 100644

--- a/chrome/browser/ui/webui/plugins_ui.cc

+++ b/chrome/browser/ui/webui/plugins_ui.cc

@@ -44,6 +44,10 @@

#include "ui/base/resource/resource_bundle.h"

#include "webkit/plugins/npapi/plugin_group.h"

+#if defined(OS_CHROMEOS)

+#include "chrome/browser/ui/webui/chromeos/ui_account_tweaks.h"

+#endif

#if defined(ENABLE_PLUGIN_INSTALLATION)

#include "chrome/browser/plugin_finder.h"

#include "chrome/browser/plugin_installer.h"

@@ -96,6 +100,9 @@ ChromeWebUIDataSource* CreatePluginsUIHTMLSource() {

source->set_json_path("strings.js");

source->add_resource_path("plugins.js", IDR_PLUGINS_JS);

source->set_default_resource(IDR_PLUGINS_HTML);

+#if defined(OS_CHROMEOS)

+ chromeos::AddAccountUITweaksLocalizedValues(source);

+#endif

return source;

}