chrome/browser/resources/plugins.html - Issue 10006028: Plugins page in BWSI session has unnecessary and misleading UI components

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/resources/plugins.html

Issue 10006028: Plugins page in BWSI session has unnecessary and misleading UI components (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Third review iteration Created 8 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/browser/resources/plugins.html

diff --git a/chrome/browser/resources/plugins.html b/chrome/browser/resources/plugins.html

index 89a77e54b3a066e6c9f08308a9ae6f6812fbd8fa..e16291779b74dd8025509feb9e3ba7e5fab90ee1 100644

--- a/chrome/browser/resources/plugins.html

+++ b/chrome/browser/resources/plugins.html

@@ -4,6 +4,10 @@

+<if expr="pp_ifdef('chromeos')">

+ <link rel="stylesheet"

+ href="chrome://resources/css/chromeos/ui_account_tweaks.css">

James Hawkins 2012/04/13 03:39:24 nit: Indentation is off. Should be 4 spaces from

+</if>

</head>

@@ -116,7 +120,7 @@

i18n-content="pluginDisabledByPolicy">(DISABLED_BY_POLICY)</span>

<span jsdisplay="enabledMode == 'enabledByPolicy'"

i18n-content="pluginEnabledByPolicy">(ENABLED_BY_POLICY)</span>

- <span>

+ <span guest-visibility="disabled">

class="disable-plugin-link"

jsvalues=".path:path"

@@ -164,7 +168,7 @@

</div>

- <div class="plugin-actions">

+ <div class="plugin-actions" guest-visibility="disabled">

<span>

class="disable-group-link"

@@ -199,8 +203,12 @@

+<script src="chrome://resources/js/cr.js"></script>

+<if expr="pp_ifdef('chromeos')">

+ <script src="chrome://resources/js/chromeos/ui_account_tweaks.js"></script>

+</if>

</body>

</html>

« no previous file with comments | « chrome/browser/resources/options2/password_manager.js ('k') | chrome/browser/resources/plugins.js » ('j') | no next file with comments »