Track URLRequestContext references in a set.

net/url_request/url_request_context.h

Index: net/url_request/url_request_context.h
diff --git a/net/url_request/url_request_context.h b/net/url_request/url_request_context.h
index f4fb5ea49279d342c706d619fb3e0da4903293bb..36db3b573ea347911e253a3ac213edd9496e0579 100644
--- a/net/url_request/url_request_context.h
+++ b/net/url_request/url_request_context.h
@@ -11,6 +11,7 @@
 #define NET_URL_REQUEST_URL_REQUEST_CONTEXT_H_
 #pragma once
 
+#include <set>

[wtc, 2012/04/05 21:37:16]

Nit: add a blank line to separate this from Chrome headers.

 #include "base/memory/ref_counted.h"
 #include "base/memory/scoped_ptr.h"
 #include "base/memory/weak_ptr.h"
@@ -189,6 +190,10 @@ class NET_EXPORT URLRequestContext
     job_factory_ = job_factory;
   }
 
+  std::set<const URLRequest*>* url_requests() const {

[wtc, 2012/04/05 21:37:16]

Please document this method. ("Gets the URLRequest objects that hold a reference
to this URLRequestContext"?)

+    return url_requests_.get();
+  }
+
  protected:
   friend class base::RefCountedThreadSafe<URLRequestContext>;
 
@@ -232,6 +237,8 @@ class NET_EXPORT URLRequestContext
   // be added to CopyFrom.
   // ---------------------------------------------------------------------------
 
+  scoped_ptr<std::set<const URLRequest*> > url_requests_;

[wtc, 2012/04/05 21:37:16]

This can be simply
    std::set<const URLRequest*> url_requests_;
to avoid one heap allocation.

The way you use this member, it doesn't need to be a scoped_ptr.

[willchan no longer on Chromium, 2012/04/06 13:51:17]

Actually it does, because URLRequest has access to a const URLRequestContext.
The pointer is const, like all the other members, so setters can't be called
anymore, but to allow modifying the actual member, the member must be a pointer
to a non-const object. Ugly, I know :P

On 2012/04/05 21:37:16, wtc wrote:

+
   DISALLOW_COPY_AND_ASSIGN(URLRequestContext);
 };