Track URLRequestContext references in a set.

net/url_request/url_request_context.h

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 // This class represents contextual information (cookies, cache, etc.)
 // that's useful when processing resource requests.
 // The class is reference-counted so that it can be cleaned up after any
 // requests that are using it have been completed.
 
 #ifndef NET_URL_REQUEST_URL_REQUEST_CONTEXT_H_
 #define NET_URL_REQUEST_URL_REQUEST_CONTEXT_H_
 #pragma once
 
+#include <set>

[wtc, 2012/04/05 21:37:16]

Nit: add a blank line to separate this from Chrome headers.

 #include "base/memory/ref_counted.h"
 #include "base/memory/scoped_ptr.h"
 #include "base/memory/weak_ptr.h"
 #include "base/threading/non_thread_safe.h"
 #include "net/base/net_export.h"
 #include "net/base/net_log.h"
 #include "net/base/ssl_config_service.h"
 #include "net/base/transport_security_state.h"
 #include "net/http/http_server_properties.h"
 #include "net/ftp/ftp_auth_cache.h"
@@ skipping 158 matching lines @@
   const std::string& referrer_charset() const { return referrer_charset_; }
   void set_referrer_charset(const std::string& charset) {
     referrer_charset_ = charset;
   }
 
   const URLRequestJobFactory* job_factory() const { return job_factory_; }
   void set_job_factory(const URLRequestJobFactory* job_factory) {
     job_factory_ = job_factory;
   }
 
+  std::set<const URLRequest*>* url_requests() const {

[wtc, 2012/04/05 21:37:16]

Please document this method. ("Gets the URLRequest objects that hold a reference
to this URLRequestContext"?)

+    return url_requests_.get();
+  }
+
  protected:
   friend class base::RefCountedThreadSafe<URLRequestContext>;
 
   virtual ~URLRequestContext();
 
  private:
   base::WeakPtrFactory<URLRequestContext> weak_factory_;
 
   // ---------------------------------------------------------------------------
   // Important: When adding any new members below, consider whether they need to
@@ skipping 23 matching lines @@
   std::string referrer_charset_;
   HttpTransactionFactory* http_transaction_factory_;
   FtpTransactionFactory* ftp_transaction_factory_;
   const URLRequestJobFactory* job_factory_;
 
   // ---------------------------------------------------------------------------
   // Important: When adding any new members below, consider whether they need to
   // be added to CopyFrom.
   // ---------------------------------------------------------------------------
 
+  scoped_ptr<std::set<const URLRequest*> > url_requests_;

[wtc, 2012/04/05 21:37:16]

This can be simply
    std::set<const URLRequest*> url_requests_;
to avoid one heap allocation.

The way you use this member, it doesn't need to be a scoped_ptr.

[willchan no longer on Chromium, 2012/04/06 13:51:17]

Actually it does, because URLRequest has access to a const URLRequestContext.
The pointer is const, like all the other members, so setters can't be called
anymore, but to allow modifying the actual member, the member must be a pointer
to a non-const object. Ugly, I know :P

On 2012/04/05 21:37:16, wtc wrote:

+
   DISALLOW_COPY_AND_ASSIGN(URLRequestContext);
 };
 
 }  // namespace net
 
 #endif  // NET_URL_REQUEST_URL_REQUEST_CONTEXT_H_