Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(614)

Issue 10006009: Track URLRequestContext references in a set. (Closed)

Created:
8 years, 8 months ago by willchan no longer on Chromium
Modified:
8 years, 8 months ago
Reviewers:
wtc
CC:
chromium-reviews, cbentzel+watch_chromium.org, darin-cc_chromium.org
Base URL:
http://git.chromium.org/chromium/src.git@master
Visibility:
Public.

Description

Track URLRequestContext references in a set. Also add code in URLRequestContext to CHECK in its destructor to make sure there are no references. This is sort of pointless right now because URLRequest holds a scoped_refptr<URLRequestContext>. My plan is to probe on canary channel with killing that off, and debugging crash reports until I've fixed the last leaks. BUG=58859 TEST=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=131126

Patch Set 1 #

Patch Set 2 : Add comments and track the number of leaked requests. #

Total comments: 5

Patch Set 3 : Nits #

Unified diffs Side-by-side diffs Delta from patch set Stats (+39 lines, -1 line) Patch
M net/url_request/url_request.cc View 1 2 2 chunks +14 lines, -0 lines 0 comments Download
M net/url_request/url_request_context.h View 1 2 3 chunks +10 lines, -0 lines 0 comments Download
M net/url_request/url_request_context.cc View 1 3 chunks +15 lines, -1 line 0 comments Download

Messages

Total messages: 5 (0 generated)
willchan no longer on Chromium
8 years, 8 months ago (2012-04-05 15:16:56 UTC) #1
wtc
Patch set 2 LGTM. I suggest some changes. https://chromiumcodereview.appspot.com/10006009/diff/1004/net/url_request/url_request.cc File net/url_request/url_request.cc (right): https://chromiumcodereview.appspot.com/10006009/diff/1004/net/url_request/url_request.cc#newcode52 net/url_request/url_request.cc:52: Nit: ...
8 years, 8 months ago (2012-04-05 21:37:15 UTC) #2
willchan no longer on Chromium
http://codereview.chromium.org/10006009/diff/1004/net/url_request/url_request_context.h File net/url_request/url_request_context.h (right): http://codereview.chromium.org/10006009/diff/1004/net/url_request/url_request_context.h#newcode240 net/url_request/url_request_context.h:240: scoped_ptr<std::set<const URLRequest*> > url_requests_; Actually it does, because URLRequest ...
8 years, 8 months ago (2012-04-06 13:51:17 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/willchan@chromium.org/10006009/1006
8 years, 8 months ago (2012-04-06 13:52:02 UTC) #4
commit-bot: I haz the power
8 years, 8 months ago (2012-04-06 15:42:43 UTC) #5
Change committed as 131126

Powered by Google App Engine
This is Rietveld 408576698