Issue 10005029: Ensure .mk files aren't included in the tab character check.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10005029: Ensure .mk files aren't included in the tab character check. (Closed)

Created:
8 years, 8 months ago by cmp

Modified:
8 years, 8 months ago

Reviewers:
Marc-Antoine Ruel (Google), M-A Ruel

CC:
chromium-reviews, Dirk Pranke, M-A Ruel

Base URL:
svn://svn.chromium.org/chrome/trunk/tools/depot_tools/

Visibility:
Public.

More Reviews

Description

Ensure .mk files aren't included in the tab character check. R=maruel@chromium.org TEST=presubmit checks pass Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=131171

Patch Set 1 #

Created: 8 years, 8 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+3 lines, -2 lines)			Patch
	M	presubmit_canned_checks.py	View		1 chunk	+3 lines, -2 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/cmp@chromium.org/10005029/1

8 years, 8 months ago (2012-04-06 19:44:00 UTC) #3

cmp

8 years, 8 months ago (2012-04-06 20:15:55 UTC) #5

fyi, after landing this i rewound my git repo to this change and re-ran git cl
presubmit.  the presubmit only noted the file was missing the license header.

Expand Messages | Collapse Messages