presubmit_canned_checks.py - Issue 10005029: Ensure .mk files aren't included in the tab character check.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: presubmit_canned_checks.py

Issue 10005029: Ensure .mk files aren't included in the tab character check. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/tools/depot_tools/

Patch Set: Created 8 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: presubmit_canned_checks.py

===================================================================

--- presubmit_canned_checks.py (revision 131044)

+++ presubmit_canned_checks.py (working copy)

@@ -271,8 +271,9 @@

# It's the default filter.

source_file_filter = input_api.FilterSourceFile

def filter_more(affected_file):

- return (not input_api.os_path.basename(affected_file.LocalPath()) in

- ('Makefile', 'makefile') and

+ basename = input_api.os_path.basename(affected_file.LocalPath())

+ return (not (basename in ('Makefile', 'makefile') or

+ basename.endswith('.mk')) and

source_file_filter(affected_file))

tabs = _FindNewViolationsOfRule(lambda _, line : '\t' not in line,

« no previous file with comments | « no previous file | no next file » | no next file with comments »