Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2737)

Unified Diff: base/threading/thread_unittest.cc

Issue 10004001: Add virtual and OVERRIDE to base/ implementation files (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Win Fix -> Missing header Created 8 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « base/threading/thread_local_unittest.cc ('k') | base/threading/watchdog_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: base/threading/thread_unittest.cc
diff --git a/base/threading/thread_unittest.cc b/base/threading/thread_unittest.cc
index 87df2524b28b060806005c46b2e82906a49d62ff..28696d9bc77f691f62ca1e15332bfd9c50bf9959 100644
--- a/base/threading/thread_unittest.cc
+++ b/base/threading/thread_unittest.cc
@@ -35,7 +35,7 @@ class SleepInsideInitThread : public Thread {
Stop();
}
- virtual void Init() {
+ virtual void Init() OVERRIDE {
base::PlatformThread::Sleep(base::TimeDelta::FromMilliseconds(500));
init_called_ = true;
}
@@ -66,18 +66,19 @@ class CaptureToEventList : public Thread {
// the order they occured in. |event_list| must remain valid for the
// lifetime of this thread.
explicit CaptureToEventList(EventList* event_list)
- : Thread("none"), event_list_(event_list) {
+ : Thread("none"),
+ event_list_(event_list) {
}
virtual ~CaptureToEventList() {
Stop();
}
- virtual void Init() {
+ virtual void Init() OVERRIDE {
event_list_->push_back(THREAD_EVENT_INIT);
}
- virtual void CleanUp() {
+ virtual void CleanUp() OVERRIDE {
event_list_->push_back(THREAD_EVENT_CLEANUP);
}
@@ -95,7 +96,7 @@ class CapturingDestructionObserver : public MessageLoop::DestructionObserver {
}
// DestructionObserver implementation:
- virtual void WillDestroyCurrentMessageLoop() {
+ virtual void WillDestroyCurrentMessageLoop() OVERRIDE {
event_list_->push_back(THREAD_EVENT_MESSAGE_LOOP_DESTROYED);
event_list_ = NULL;
}
« no previous file with comments | « base/threading/thread_local_unittest.cc ('k') | base/threading/watchdog_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698