Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(661)

Unified Diff: base/threading/thread_local_unittest.cc

Issue 10004001: Add virtual and OVERRIDE to base/ implementation files (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Win Fix -> Missing header Created 8 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « base/threading/thread_local_storage_unittest.cc ('k') | base/threading/thread_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: base/threading/thread_local_unittest.cc
diff --git a/base/threading/thread_local_unittest.cc b/base/threading/thread_local_unittest.cc
index ba12898f31ff9cb6c18998655bd92ea83de02974..d09fff4b2cae7e0135b67688a5b42cf3b9fed885 100644
--- a/base/threading/thread_local_unittest.cc
+++ b/base/threading/thread_local_unittest.cc
@@ -17,8 +17,10 @@ class ThreadLocalTesterBase : public base::DelegateSimpleThreadPool::Delegate {
typedef base::ThreadLocalPointer<ThreadLocalTesterBase> TLPType;
ThreadLocalTesterBase(TLPType* tlp, base::WaitableEvent* done)
- : tlp_(tlp), done_(done) { }
- ~ThreadLocalTesterBase() { }
+ : tlp_(tlp),
+ done_(done) {
+ }
+ virtual ~ThreadLocalTesterBase() {}
protected:
TLPType* tlp_;
@@ -28,12 +30,14 @@ class ThreadLocalTesterBase : public base::DelegateSimpleThreadPool::Delegate {
class SetThreadLocal : public ThreadLocalTesterBase {
public:
SetThreadLocal(TLPType* tlp, base::WaitableEvent* done)
- : ThreadLocalTesterBase(tlp, done), val_(NULL) { }
- ~SetThreadLocal() { }
+ : ThreadLocalTesterBase(tlp, done),
+ val_(NULL) {
+ }
+ virtual ~SetThreadLocal() {}
void set_value(ThreadLocalTesterBase* val) { val_ = val; }
- virtual void Run() {
+ virtual void Run() OVERRIDE {
DCHECK(!done_->IsSignaled());
tlp_->Set(val_);
done_->Signal();
@@ -46,12 +50,14 @@ class SetThreadLocal : public ThreadLocalTesterBase {
class GetThreadLocal : public ThreadLocalTesterBase {
public:
GetThreadLocal(TLPType* tlp, base::WaitableEvent* done)
- : ThreadLocalTesterBase(tlp, done), ptr_(NULL) { }
- ~GetThreadLocal() { }
+ : ThreadLocalTesterBase(tlp, done),
+ ptr_(NULL) {
+ }
+ virtual ~GetThreadLocal() {}
void set_ptr(ThreadLocalTesterBase** ptr) { ptr_ = ptr; }
- virtual void Run() {
+ virtual void Run() OVERRIDE {
DCHECK(!done_->IsSignaled());
*ptr_ = tlp_->Get();
done_->Signal();
« no previous file with comments | « base/threading/thread_local_storage_unittest.cc ('k') | base/threading/thread_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698