Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2140)

Unified Diff: base/threading/thread_local_unittest.cc

Issue 10004001: Add virtual and OVERRIDE to base/ implementation files (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Feedback from chromium-dev Created 8 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: base/threading/thread_local_unittest.cc
diff --git a/base/threading/thread_local_unittest.cc b/base/threading/thread_local_unittest.cc
index ba12898f31ff9cb6c18998655bd92ea83de02974..cf3cca324fa9e335f81cdbd7db9637671057ec1c 100644
--- a/base/threading/thread_local_unittest.cc
+++ b/base/threading/thread_local_unittest.cc
@@ -18,7 +18,7 @@ class ThreadLocalTesterBase : public base::DelegateSimpleThreadPool::Delegate {
ThreadLocalTesterBase(TLPType* tlp, base::WaitableEvent* done)
: tlp_(tlp), done_(done) { }
jar (doing other things) 2012/04/05 21:11:30 nit: one initializer per line.
- ~ThreadLocalTesterBase() { }
+ virtual ~ThreadLocalTesterBase() { }
protected:
TLPType* tlp_;
@@ -29,11 +29,11 @@ class SetThreadLocal : public ThreadLocalTesterBase {
public:
SetThreadLocal(TLPType* tlp, base::WaitableEvent* done)
: ThreadLocalTesterBase(tlp, done), val_(NULL) { }
jar (doing other things) 2012/04/05 21:11:30 nit: one init per line.
- ~SetThreadLocal() { }
+ virtual ~SetThreadLocal() { }
void set_value(ThreadLocalTesterBase* val) { val_ = val; }
- virtual void Run() {
+ virtual void Run() OVERRIDE {
DCHECK(!done_->IsSignaled());
tlp_->Set(val_);
done_->Signal();
@@ -47,11 +47,11 @@ class GetThreadLocal : public ThreadLocalTesterBase {
public:
GetThreadLocal(TLPType* tlp, base::WaitableEvent* done)
: ThreadLocalTesterBase(tlp, done), ptr_(NULL) { }
- ~GetThreadLocal() { }
+ virtual ~GetThreadLocal() { }
void set_ptr(ThreadLocalTesterBase** ptr) { ptr_ = ptr; }
- virtual void Run() {
+ virtual void Run() OVERRIDE {
DCHECK(!done_->IsSignaled());
*ptr_ = tlp_->Get();
done_->Signal();

Powered by Google App Engine
This is Rietveld 408576698