Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(115)

Side by Side Diff: base/threading/thread_local_unittest.cc

Issue 10004001: Add virtual and OVERRIDE to base/ implementation files (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Feedback from chromium-dev Created 8 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 // Copyright (c) 2010 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2010 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "base/logging.h" 5 #include "base/logging.h"
6 #include "base/threading/simple_thread.h" 6 #include "base/threading/simple_thread.h"
7 #include "base/threading/thread_local.h" 7 #include "base/threading/thread_local.h"
8 #include "base/synchronization/waitable_event.h" 8 #include "base/synchronization/waitable_event.h"
9 #include "testing/gtest/include/gtest/gtest.h" 9 #include "testing/gtest/include/gtest/gtest.h"
10 10
11 namespace base { 11 namespace base {
12 12
13 namespace { 13 namespace {
14 14
15 class ThreadLocalTesterBase : public base::DelegateSimpleThreadPool::Delegate { 15 class ThreadLocalTesterBase : public base::DelegateSimpleThreadPool::Delegate {
16 public: 16 public:
17 typedef base::ThreadLocalPointer<ThreadLocalTesterBase> TLPType; 17 typedef base::ThreadLocalPointer<ThreadLocalTesterBase> TLPType;
18 18
19 ThreadLocalTesterBase(TLPType* tlp, base::WaitableEvent* done) 19 ThreadLocalTesterBase(TLPType* tlp, base::WaitableEvent* done)
20 : tlp_(tlp), done_(done) { } 20 : tlp_(tlp), done_(done) { }
jar (doing other things) 2012/04/05 21:11:30 nit: one initializer per line.
21 ~ThreadLocalTesterBase() { } 21 virtual ~ThreadLocalTesterBase() { }
22 22
23 protected: 23 protected:
24 TLPType* tlp_; 24 TLPType* tlp_;
25 base::WaitableEvent* done_; 25 base::WaitableEvent* done_;
26 }; 26 };
27 27
28 class SetThreadLocal : public ThreadLocalTesterBase { 28 class SetThreadLocal : public ThreadLocalTesterBase {
29 public: 29 public:
30 SetThreadLocal(TLPType* tlp, base::WaitableEvent* done) 30 SetThreadLocal(TLPType* tlp, base::WaitableEvent* done)
31 : ThreadLocalTesterBase(tlp, done), val_(NULL) { } 31 : ThreadLocalTesterBase(tlp, done), val_(NULL) { }
jar (doing other things) 2012/04/05 21:11:30 nit: one init per line.
32 ~SetThreadLocal() { } 32 virtual ~SetThreadLocal() { }
33 33
34 void set_value(ThreadLocalTesterBase* val) { val_ = val; } 34 void set_value(ThreadLocalTesterBase* val) { val_ = val; }
35 35
36 virtual void Run() { 36 virtual void Run() OVERRIDE {
37 DCHECK(!done_->IsSignaled()); 37 DCHECK(!done_->IsSignaled());
38 tlp_->Set(val_); 38 tlp_->Set(val_);
39 done_->Signal(); 39 done_->Signal();
40 } 40 }
41 41
42 private: 42 private:
43 ThreadLocalTesterBase* val_; 43 ThreadLocalTesterBase* val_;
44 }; 44 };
45 45
46 class GetThreadLocal : public ThreadLocalTesterBase { 46 class GetThreadLocal : public ThreadLocalTesterBase {
47 public: 47 public:
48 GetThreadLocal(TLPType* tlp, base::WaitableEvent* done) 48 GetThreadLocal(TLPType* tlp, base::WaitableEvent* done)
49 : ThreadLocalTesterBase(tlp, done), ptr_(NULL) { } 49 : ThreadLocalTesterBase(tlp, done), ptr_(NULL) { }
50 ~GetThreadLocal() { } 50 virtual ~GetThreadLocal() { }
51 51
52 void set_ptr(ThreadLocalTesterBase** ptr) { ptr_ = ptr; } 52 void set_ptr(ThreadLocalTesterBase** ptr) { ptr_ = ptr; }
53 53
54 virtual void Run() { 54 virtual void Run() OVERRIDE {
55 DCHECK(!done_->IsSignaled()); 55 DCHECK(!done_->IsSignaled());
56 *ptr_ = tlp_->Get(); 56 *ptr_ = tlp_->Get();
57 done_->Signal(); 57 done_->Signal();
58 } 58 }
59 59
60 private: 60 private:
61 ThreadLocalTesterBase** ptr_; 61 ThreadLocalTesterBase** ptr_;
62 }; 62 };
63 63
64 } // namespace 64 } // namespace
(...skipping 89 matching lines...) Expand 10 before | Expand all | Expand 10 after
154 } 154 }
155 155
156 // Our slot should have been freed, we're all reset. 156 // Our slot should have been freed, we're all reset.
157 { 157 {
158 base::ThreadLocalBoolean tlb; 158 base::ThreadLocalBoolean tlb;
159 EXPECT_FALSE(tlb.Get()); 159 EXPECT_FALSE(tlb.Get());
160 } 160 }
161 } 161 }
162 162
163 } // namespace base 163 } // namespace base
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698