Chromium Code Reviews| Index: base/threading/thread_local_unittest.cc |
| diff --git a/base/threading/thread_local_unittest.cc b/base/threading/thread_local_unittest.cc |
| index ba12898f31ff9cb6c18998655bd92ea83de02974..cf3cca324fa9e335f81cdbd7db9637671057ec1c 100644 |
| --- a/base/threading/thread_local_unittest.cc |
| +++ b/base/threading/thread_local_unittest.cc |
| @@ -18,7 +18,7 @@ class ThreadLocalTesterBase : public base::DelegateSimpleThreadPool::Delegate { |
| ThreadLocalTesterBase(TLPType* tlp, base::WaitableEvent* done) |
| : tlp_(tlp), done_(done) { } |
|
jar (doing other things)
2012/04/05 21:11:30
nit: one initializer per line.
|
| - ~ThreadLocalTesterBase() { } |
| + virtual ~ThreadLocalTesterBase() { } |
| protected: |
| TLPType* tlp_; |
| @@ -29,11 +29,11 @@ class SetThreadLocal : public ThreadLocalTesterBase { |
| public: |
| SetThreadLocal(TLPType* tlp, base::WaitableEvent* done) |
| : ThreadLocalTesterBase(tlp, done), val_(NULL) { } |
|
jar (doing other things)
2012/04/05 21:11:30
nit: one init per line.
|
| - ~SetThreadLocal() { } |
| + virtual ~SetThreadLocal() { } |
| void set_value(ThreadLocalTesterBase* val) { val_ = val; } |
| - virtual void Run() { |
| + virtual void Run() OVERRIDE { |
| DCHECK(!done_->IsSignaled()); |
| tlp_->Set(val_); |
| done_->Signal(); |
| @@ -47,11 +47,11 @@ class GetThreadLocal : public ThreadLocalTesterBase { |
| public: |
| GetThreadLocal(TLPType* tlp, base::WaitableEvent* done) |
| : ThreadLocalTesterBase(tlp, done), ptr_(NULL) { } |
| - ~GetThreadLocal() { } |
| + virtual ~GetThreadLocal() { } |
| void set_ptr(ThreadLocalTesterBase** ptr) { ptr_ = ptr; } |
| - virtual void Run() { |
| + virtual void Run() OVERRIDE { |
| DCHECK(!done_->IsSignaled()); |
| *ptr_ = tlp_->Get(); |
| done_->Signal(); |