chrome/browser/extensions/extension_view.cc - Issue 100033: Synchronously update the loading state when a load starts so that the UI will...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/extension_view.cc

Issue 100033: Synchronously update the loading state when a load starts so that the UI will... (Closed) Base URL: svn://chrome-svn/chrome/trunk/src/

Patch Set: '' Created 11 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/browser/extensions/extension_view.cc

===================================================================

--- chrome/browser/extensions/extension_view.cc (revision 14707)

+++ chrome/browser/extensions/extension_view.cc (working copy)

@@ -53,8 +53,7 @@

ShowIfCompletelyLoaded();

}

-void ExtensionView::DidStopLoading(RenderViewHost* render_view_host,

- int32 page_id) {

+void ExtensionView::DidStopLoading(RenderViewHost* render_view_host) {

render_view_host->WasResized();

did_stop_loading_ = true;

ShowIfCompletelyLoaded();

@@ -111,8 +110,7 @@

render_view_host()->JavaScriptMessageBoxClosed(reply_msg, true, L"");

}

-void ExtensionView::DidStartLoading(RenderViewHost* render_view_host,

- int32 page_id) {

+void ExtensionView::DidStartLoading(RenderViewHost* render_view_host) {

static const StringPiece toolstrip_css(

ResourceBundle::GetSharedInstance().GetRawDataResource(

IDR_EXTENSIONS_TOOLSTRIP_CSS));

« no previous file with comments | « chrome/browser/extensions/extension_view.h ('k') | chrome/browser/renderer_host/render_view_host.h » ('j') | no next file with comments »