Synchronously update the loading state when a load starts so that the UI will...

chrome/browser/extensions/extension_view.cc

 // Copyright (c) 2006-2009 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/extensions/extension_view.h"
 
 #include "base/command_line.h"
 #include "chrome/browser/browser.h"
 #include "chrome/browser/character_encoding.h"
 #include "chrome/browser/extensions/extension.h"
@@ skipping 35 matching lines @@
     SetVisible(true);
     DidContentsPreferredWidthChange(pending_preferred_width_);
   }
 }
 
 void ExtensionView::SetBackground(const SkBitmap& background) {
   HWNDHtmlView::SetBackground(background);
   ShowIfCompletelyLoaded();
 }
 
-void ExtensionView::DidStopLoading(RenderViewHost* render_view_host,
-      int32 page_id) {
+void ExtensionView::DidStopLoading(RenderViewHost* render_view_host) {
   render_view_host->WasResized();
   did_stop_loading_ = true;
   ShowIfCompletelyLoaded();
 }
 
 void ExtensionView::DidContentsPreferredWidthChange(const int pref_width) {
   // Don't actually do anything with this information until we have been shown.
   // Size changes will not be honored by lower layers while we are hidden.
   if (!IsVisible()) {
     pending_preferred_width_ = pref_width;
@@ skipping 36 matching lines @@
     const GURL& frame_url,
     const int flags,
     IPC::Message* reply_msg,
     bool* did_suppress_message) {
   // Automatically cancel the javascript alert (otherwise the renderer hangs
   // indefinitely).
   *did_suppress_message = true;
   render_view_host()->JavaScriptMessageBoxClosed(reply_msg, true, L"");
 }
 
-void ExtensionView::DidStartLoading(RenderViewHost* render_view_host,
-                                    int32 page_id) {
+void ExtensionView::DidStartLoading(RenderViewHost* render_view_host) {
   static const StringPiece toolstrip_css(
       ResourceBundle::GetSharedInstance().GetRawDataResource(
           IDR_EXTENSIONS_TOOLSTRIP_CSS));
   render_view_host->InsertCSSInWebFrame(L"", toolstrip_css.as_string());
 }
 
 RenderViewHostDelegate::View* ExtensionView::GetViewDelegate() const {
   // TODO(erikkay) this is unfortunate.  The interface declares that this method
   // must be const (no good reason for it as far as I can tell) which means you
   // can't return self without doing this const_cast.  Either we need to change
@@ skipping 43 matching lines @@
 }
 
 void ExtensionView::UpdateDragCursor(bool is_drop_target) {
 }
 
 void ExtensionView::TakeFocus(bool reverse) {
 }
 
 void ExtensionView::HandleKeyboardEvent(const NativeWebKeyboardEvent& event) {
 }