Issue 100031: Write a test for my previous patch to fix a crash in back/forward navigations...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 100031: Write a test for my previous patch to fix a crash in back/forward navigations... (Closed)

Created:
11 years, 8 months ago by brettw

Modified:
9 years, 7 months ago

Reviewers:
sky

CC:
chromium-reviews_googlegroups.com

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

Write a test for my previous patch to fix a crash in back/forward navigations creating new tabs. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=14819

Created: 11 years, 8 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+88 lines, -10 lines)			Patch
M	chrome/browser/browser_commands_unittest.cc	View	1 chunk	+66 lines, -0 lines	0 comments	Download
M	chrome/test/browser_with_test_window_test.h	View	1 chunk	+3 lines, -4 lines	0 comments	Download
M	chrome/test/browser_with_test_window_test.cc	View	2 chunks	+19 lines, -6 lines	0 comments	Download

Total messages: 2 (0 generated)

brettw

I made CommitPendingLoad smarter and allowed it to commit both new navigations and renavigations for ...

11 years, 8 months ago (2009-04-27 05:31:44 UTC) #1

LGTM