Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(37)

Unified Diff: chrome/test/browser_with_test_window_test.h

Issue 100031: Write a test for my previous patch to fix a crash in back/forward navigations... (Closed) Base URL: svn://chrome-svn/chrome/trunk/src/
Patch Set: Created 11 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/browser_commands_unittest.cc ('k') | chrome/test/browser_with_test_window_test.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/test/browser_with_test_window_test.h
===================================================================
--- chrome/test/browser_with_test_window_test.h (revision 14577)
+++ chrome/test/browser_with_test_window_test.h (working copy)
@@ -58,10 +58,9 @@
// This is a convenience function. The new tab will be added at index 0.
void AddTab(Browser* browser, const GURL& url);
- // Commits the pending load as if we went to a new page (as opposed to back or
- // forward).
- void CommitPendingLoadAsNewNavigation(NavigationController* controller,
- const GURL& url);
+ // Commits the pending load on the given controller. It will keep the
+ // URL of the pending load. If there is no pending load, this does nothing.
+ void CommitPendingLoad(NavigationController* controller);
// Creates a pending navigation on the given navigation controller to the
// given URL with the default parameters and the commits the load with a page
« no previous file with comments | « chrome/browser/browser_commands_unittest.cc ('k') | chrome/test/browser_with_test_window_test.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698