Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(480)

Issue 9303020: Move all samples but swarm from client/samples/ to samples/ . (Closed)

Created:
8 years, 10 months ago by dgrove
Modified:
8 years, 10 months ago
Reviewers:
Emily Fortuna
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Move all samples but swarm from client/samples/ to samples/ . Committed: https://code.google.com/p/dart/source/detail?r=3733

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+24 lines, -2385 lines) Patch
D client/samples/dartcombat/README View 1 chunk +0 lines, -36 lines 0 comments Download
D client/samples/dartcombat/dartcombat.css View 1 chunk +0 lines, -172 lines 0 comments Download
D client/samples/dartcombat/dartcombat.dart View 1 chunk +0 lines, -12 lines 0 comments Download
D client/samples/dartcombat/dartcombat.html View 1 chunk +0 lines, -15 lines 0 comments Download
D client/samples/dartcombat/dartcombatlib.dart View 1 chunk +0 lines, -13 lines 0 comments Download
D client/samples/dartcombat/grids.dart View 1 chunk +0 lines, -97 lines 0 comments Download
D client/samples/dartcombat/icons.gif View Binary file 0 comments Download
D client/samples/dartcombat/player.dart View 1 chunk +0 lines, -115 lines 0 comments Download
D client/samples/dartcombat/setup.dart View 1 chunk +0 lines, -98 lines 0 comments Download
D client/samples/dartcombat/state.dart View 1 chunk +0 lines, -307 lines 0 comments Download
D client/samples/dartcombat/views.dart View 1 chunk +0 lines, -304 lines 0 comments Download
D client/samples/logo/dart-logo.svg View 1 chunk +0 lines, -3 lines 0 comments Download
D client/samples/logo/logo.css View 1 chunk +0 lines, -26 lines 0 comments Download
D client/samples/logo/logo.dart View 1 chunk +0 lines, -199 lines 0 comments Download
D client/samples/logo/logo.html View 1 chunk +0 lines, -25 lines 0 comments Download
D client/samples/spirodraw/ColorPicker.dart View 1 chunk +0 lines, -113 lines 0 comments Download
D client/samples/spirodraw/Spirodraw.dart View 1 chunk +0 lines, -310 lines 0 comments Download
D client/samples/spirodraw/spirodraw.css View 1 chunk +0 lines, -105 lines 0 comments Download
D client/samples/spirodraw/spirodraw.html View 1 chunk +0 lines, -120 lines 0 comments Download
M client/tests/client/client.status View 2 chunks +0 lines, -3 lines 0 comments Download
D client/tests/client/samples/dartcombat/dartcombat_tests.dart View 1 chunk +0 lines, -149 lines 0 comments Download
M frog/leg/scanner/source_list.dart View 1 chunk +8 lines, -8 lines 0 comments Download
M samples/tests/samples/samples.status View 1 chunk +14 lines, -4 lines 2 comments Download
A + samples/tests/samples/src/dartcombat/DartCombatTest.dart View 1 chunk +2 lines, -2 lines 0 comments Download
D samples/tests/samples/src/dartcombat/dartcombat_tests.dart View 1 chunk +0 lines, -149 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
dgrove
8 years, 10 months ago (2012-01-31 02:05:36 UTC) #1
Jennifer Messerly
On 2012/01/31 02:05:36, dgrove wrote: I see the D's but not the A's? unless that ...
8 years, 10 months ago (2012-01-31 02:07:24 UTC) #2
dgrove
On 2012/01/31 02:07:24, John Messerly wrote: > On 2012/01/31 02:05:36, dgrove wrote: > > I ...
8 years, 10 months ago (2012-01-31 02:11:55 UTC) #3
Emily Fortuna
I'm assuming this is another instance of where you added all of the dartcombat files ...
8 years, 10 months ago (2012-01-31 02:15:27 UTC) #4
dgrove
8 years, 10 months ago (2012-01-31 16:18:27 UTC) #5
http://codereview.chromium.org/9303020/diff/1/samples/tests/samples/samples.s...
File samples/tests/samples/samples.status (right):

http://codereview.chromium.org/9303020/diff/1/samples/tests/samples/samples.s...
samples/tests/samples/samples.status:30: dartcombat/DartCombatTest: Skip # Bug
5279716
On 2012/01/31 02:15:27, Emily Fortuna wrote:
> Are there any tests that were running as part of samples before? If so, you
> should ensure that all the others (I see folders for actors, clock, matrix,
etc)
> also run with no errors on Dartium and Chromium, since previously we skipped
> everything in this folder for Dartium and Chromium.

Right - we need to be set up to actually run tests in samples. I've checked all
of the other variants.

Powered by Google App Engine
This is Rietveld 408576698