Move utils.h and utils.cc from runtime/vm to runtime/platform

Move utils.h and utils.cc from runtime/vm to runtime/platform

Moved additional parts of globals.h from vm/ to platform/ to support
types and constants used by utils.*.

R=ager@google.com, iposva@google.com

BUG=
TEST=

Committed: https://code.google.com/p/dart/source/detail?r=3337

[Søren Gjesse, 2012-01-13 14:49:39]

This is based on http://codereview.chromium.org/9189003/ where assert.h and
assert.cc have already been moved to platform/runtime.

This is a prerequisite for sharing PowerOfTwo and hash functions with the
hashmap being added in http://codereview.chromium.org/9186035/.

[Mads Ager (chromium), 2012-01-13 15:10:08]

LGTM, with the include order fixed in the cc files.

http://codereview.chromium.org/9209001/diff/1/runtime/vm/assembler.cc
File runtime/vm/assembler.cc (right):

http://codereview.chromium.org/9209001/diff/1/runtime/vm/assembler.cc#newcode6
runtime/vm/assembler.cc:6: #include "vm/assembler.h"
Move assembler.h above utils.h.

http://codereview.chromium.org/9209001/diff/1/runtime/vm/debuginfo_linux.cc
File runtime/vm/debuginfo_linux.cc (right):

http://codereview.chromium.org/9209001/diff/1/runtime/vm/debuginfo_linux.cc#n...
runtime/vm/debuginfo_linux.cc:6: #include "vm/debuginfo.h"
Keep as first line.

http://codereview.chromium.org/9209001/diff/1/runtime/vm/heap.cc
File runtime/vm/heap.cc (right):

http://codereview.chromium.org/9209001/diff/1/runtime/vm/heap.cc#newcode9
runtime/vm/heap.cc:9: #include "vm/heap.h"
Move to the top.

http://codereview.chromium.org/9209001/diff/1/runtime/vm/port.cc
File runtime/vm/port.cc (right):

http://codereview.chromium.org/9209001/diff/1/runtime/vm/port.cc#newcode8
runtime/vm/port.cc:8: #include "vm/port.h"
Move back?

http://codereview.chromium.org/9209001/diff/1/runtime/vm/virtual_memory_macos.cc
File runtime/vm/virtual_memory_macos.cc (right):

http://codereview.chromium.org/9209001/diff/1/runtime/vm/virtual_memory_macos...
runtime/vm/virtual_memory_macos.cc:10: y#include "vm/virtual_memory.h"
Accidental edit.

[Ivan Posva, 2012-01-13 23:51:01]

We should really check if there are other things we want to move into the shared
globals.h.

And again include order.

-Ivan

http://codereview.chromium.org/9209001/diff/1/runtime/platform/globals.h
File runtime/platform/globals.h (right):

http://codereview.chromium.org/9209001/diff/1/runtime/platform/globals.h#newc...
runtime/platform/globals.h:144: // to support the handle operations.
This is not needed in platform/globals.h.

http://codereview.chromium.org/9209001/diff/1/runtime/vm/disassembler_ia32.cc
File runtime/vm/disassembler_ia32.cc (right):

http://codereview.chromium.org/9209001/diff/1/runtime/vm/disassembler_ia32.cc...
runtime/vm/disassembler_ia32.cc:5: #include "platform/utils.h"
Please move this inide the #if defined, only the globals should be outside as it
defines the value used in the conditional compilation.

http://codereview.chromium.org/9209001/diff/1/runtime/vm/disassembler_ia32.cc...
runtime/vm/disassembler_ia32.cc:11: #include "vm/disassembler.h"
First line inside the #if defined area.

http://codereview.chromium.org/9209001/diff/1/runtime/vm/disassembler_x64.cc
File runtime/vm/disassembler_x64.cc (right):

http://codereview.chromium.org/9209001/diff/1/runtime/vm/disassembler_x64.cc#...
runtime/vm/disassembler_x64.cc:12: #include "platform/assert.h"
ditto. Please move back inside, missed this in the other review.

http://codereview.chromium.org/9209001/diff/1/runtime/vm/globals.h
File runtime/vm/globals.h (right):

http://codereview.chromium.org/9209001/diff/1/runtime/vm/globals.h#newcode8
runtime/vm/globals.h:8: // This file contains global definitions for the VM
library only. Anything that
Are there other parts in this file that do not depend on the vm/ implementation
and could also move into the platform/ header?

http://codereview.chromium.org/9209001/diff/1/runtime/vm/virtual_memory.cc
File runtime/vm/virtual_memory.cc (right):

http://codereview.chromium.org/9209001/diff/1/runtime/vm/virtual_memory.cc#ne...
runtime/vm/virtual_memory.cc:7: #include "vm/virtual_memory.h"
First here and in other files.

[Søren Gjesse, 2012-01-16 10:53:00]

Rebased after updates to http://codereview.chromium.org/9189003.

Addressed all comments.

http://codereview.chromium.org/9209001/diff/1/runtime/platform/globals.h
File runtime/platform/globals.h (right):

http://codereview.chromium.org/9209001/diff/1/runtime/platform/globals.h#newc...
runtime/platform/globals.h:144: // to support the handle operations.
On 2012/01/13 23:51:01, Ivan Posva wrote:
> This is not needed in platform/globals.h.

Moved back to vm/globals.h

http://codereview.chromium.org/9209001/diff/1/runtime/vm/assembler.cc
File runtime/vm/assembler.cc (right):

http://codereview.chromium.org/9209001/diff/1/runtime/vm/assembler.cc#newcode6
runtime/vm/assembler.cc:6: #include "vm/assembler.h"
On 2012/01/13 15:10:09, Mads Sig Ager wrote:
> Move assembler.h above utils.h.

Done.

http://codereview.chromium.org/9209001/diff/1/runtime/vm/debuginfo_linux.cc
File runtime/vm/debuginfo_linux.cc (right):

http://codereview.chromium.org/9209001/diff/1/runtime/vm/debuginfo_linux.cc#n...
runtime/vm/debuginfo_linux.cc:6: #include "vm/debuginfo.h"
On 2012/01/13 15:10:09, Mads Sig Ager wrote:
> Keep as first line.

Done.

http://codereview.chromium.org/9209001/diff/1/runtime/vm/disassembler_ia32.cc
File runtime/vm/disassembler_ia32.cc (right):

http://codereview.chromium.org/9209001/diff/1/runtime/vm/disassembler_ia32.cc...
runtime/vm/disassembler_ia32.cc:5: #include "platform/utils.h"
On 2012/01/13 23:51:01, Ivan Posva wrote:
> Please move this inide the #if defined, only the globals should be outside as
it
> defines the value used in the conditional compilation.

Done.

http://codereview.chromium.org/9209001/diff/1/runtime/vm/disassembler_ia32.cc...
runtime/vm/disassembler_ia32.cc:11: #include "vm/disassembler.h"
On 2012/01/13 23:51:01, Ivan Posva wrote:
> First line inside the #if defined area.

Done.

http://codereview.chromium.org/9209001/diff/1/runtime/vm/disassembler_x64.cc
File runtime/vm/disassembler_x64.cc (right):

http://codereview.chromium.org/9209001/diff/1/runtime/vm/disassembler_x64.cc#...
runtime/vm/disassembler_x64.cc:12: #include "platform/assert.h"
On 2012/01/13 23:51:01, Ivan Posva wrote:
> ditto. Please move back inside, missed this in the other review.

Done.

http://codereview.chromium.org/9209001/diff/1/runtime/vm/globals.h
File runtime/vm/globals.h (right):

http://codereview.chromium.org/9209001/diff/1/runtime/vm/globals.h#newcode8
runtime/vm/globals.h:8: // This file contains global definitions for the VM
library only. Anything that
On 2012/01/13 23:51:01, Ivan Posva wrote:
> Are there other parts in this file that do not depend on the vm/
implementation
> and could also move into the platform/ header?

Moved the template functions implicit_cast, down_cast, bit_cast and bit_copy.

This leaves only ARRAY_SIZE, kOffsetOfPtr, OFFSET_OF,  OFFSET_OF_RETURNED_VALUE,
cpp_vtable and ALIGN16 in vm/globals.h.

http://codereview.chromium.org/9209001/diff/1/runtime/vm/heap.cc
File runtime/vm/heap.cc (right):

http://codereview.chromium.org/9209001/diff/1/runtime/vm/heap.cc#newcode9
runtime/vm/heap.cc:9: #include "vm/heap.h"
On 2012/01/13 15:10:09, Mads Sig Ager wrote:
> Move to the top.

Done.

http://codereview.chromium.org/9209001/diff/1/runtime/vm/port.cc
File runtime/vm/port.cc (right):

http://codereview.chromium.org/9209001/diff/1/runtime/vm/port.cc#newcode8
runtime/vm/port.cc:8: #include "vm/port.h"
On 2012/01/13 15:10:09, Mads Sig Ager wrote:
> Move back?

Done.

http://codereview.chromium.org/9209001/diff/1/runtime/vm/virtual_memory.cc
File runtime/vm/virtual_memory.cc (right):

http://codereview.chromium.org/9209001/diff/1/runtime/vm/virtual_memory.cc#ne...
runtime/vm/virtual_memory.cc:7: #include "vm/virtual_memory.h"
On 2012/01/13 23:51:01, Ivan Posva wrote:
> First here and in other files.

Done.

http://codereview.chromium.org/9209001/diff/1/runtime/vm/virtual_memory_macos.cc
File runtime/vm/virtual_memory_macos.cc (right):

http://codereview.chromium.org/9209001/diff/1/runtime/vm/virtual_memory_macos...
runtime/vm/virtual_memory_macos.cc:10: y#include "vm/virtual_memory.h"
On 2012/01/13 15:10:09, Mads Sig Ager wrote:
> Accidental edit.

Done.

[Mads Ager (google), 2012-01-16 11:38:46]

LGTM, with a couple of comments.

http://codereview.chromium.org/9209001/diff/12003/runtime/bin/dartutils.cc
File runtime/bin/dartutils.cc (left):

http://codereview.chromium.org/9209001/diff/12003/runtime/bin/dartutils.cc#ol...
runtime/bin/dartutils.cc:6: 
Could you add this line back to separate out the header that is implemented?

http://codereview.chromium.org/9209001/diff/12003/runtime/vm/bigint_store.h
File runtime/vm/bigint_store.h (right):

http://codereview.chromium.org/9209001/diff/12003/runtime/vm/bigint_store.h#n...
runtime/vm/bigint_store.h:9: #include "vm/isolate.h"
Why is this needed here when it wasn't before? Has some VM include been removed
from vm/globals.h?

http://codereview.chromium.org/9209001/diff/12003/runtime/vm/disassembler_arm.cc
File runtime/vm/disassembler_arm.cc (right):

http://codereview.chromium.org/9209001/diff/12003/runtime/vm/disassembler_arm...
runtime/vm/disassembler_arm.cc:8: #include "platform/globals.h"  // Needed here
to get TARGET_ARCH_ARM.
Maybe we should keep all the globals.h includes in the vm directory pointing to
vm/globals.h to avoid confusion?

If you do that here, remember the other disassembler files as well.

http://codereview.chromium.org/9209001/diff/12003/runtime/vm/isolate.cc
File runtime/vm/isolate.cc (right):

http://codereview.chromium.org/9209001/diff/12003/runtime/vm/isolate.cc#newco...
runtime/vm/isolate.cc:16: #include "vm/isolate.h"
Undo this change.

[Søren Gjesse, 2012-01-16 12:55:30]

http://codereview.chromium.org/9209001/diff/12003/runtime/bin/dartutils.cc
File runtime/bin/dartutils.cc (left):

http://codereview.chromium.org/9209001/diff/12003/runtime/bin/dartutils.cc#ol...
runtime/bin/dartutils.cc:6: 
On 2012/01/16 11:38:47, Mads Ager wrote:
> Could you add this line back to separate out the header that is implemented?

Done.

http://codereview.chromium.org/9209001/diff/12003/runtime/vm/bigint_store.h
File runtime/vm/bigint_store.h (right):

http://codereview.chromium.org/9209001/diff/12003/runtime/vm/bigint_store.h#n...
runtime/vm/bigint_store.h:9: #include "vm/isolate.h"
On 2012/01/16 11:38:47, Mads Ager wrote:
> Why is this needed here when it wasn't before? Has some VM include been
removed
> from vm/globals.h?

This was due to the wrong ordering of headers in isolate.cc. isolate.h was then
included after bigint_store.h causing Isolate to not be defined. The include
order in isolate.cc is fixed, but I have kept this new include here as this .h
file uses Isolate.

http://codereview.chromium.org/9209001/diff/12003/runtime/vm/disassembler_arm.cc
File runtime/vm/disassembler_arm.cc (right):

http://codereview.chromium.org/9209001/diff/12003/runtime/vm/disassembler_arm...
runtime/vm/disassembler_arm.cc:8: #include "platform/globals.h"  // Needed here
to get TARGET_ARCH_ARM.
On 2012/01/16 11:38:47, Mads Ager wrote:
> Maybe we should keep all the globals.h includes in the vm directory pointing
to
> vm/globals.h to avoid confusion?
> 
> If you do that here, remember the other disassembler files as well.

Done.

http://codereview.chromium.org/9209001/diff/12003/runtime/vm/isolate.cc
File runtime/vm/isolate.cc (right):

http://codereview.chromium.org/9209001/diff/12003/runtime/vm/isolate.cc#newco...
runtime/vm/isolate.cc:16: #include "vm/isolate.h"
On 2012/01/16 11:38:47, Mads Ager wrote:
> Undo this change.

Done.