Issue 9199002: Support various range methods on NodeList.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 9199002: Support various range methods on NodeList. (Closed)

Created:
8 years, 11 months ago by nweiz

Modified:
8 years, 11 months ago

Reviewers:
Jacob

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Support various range methods on NodeList. Fix issue 1077. TBR Committed: https://code.google.com/p/dart/source/detail?r=3309

Patch Set 2 : Merge with HEAD #

Total comments: 2

Created: 8 years, 11 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+249 lines, -16 lines)			Patch
M	client/html/release/htmlimpl.dart	View	3 chunks	+46 lines, -4 lines	0 comments	Download
M	client/html/src/NodeWrappingImplementation.dart	View	3 chunks	+46 lines, -4 lines	2 comments	Download
M	client/tests/client/html/NodeTests.dart	View	2 chunks	+157 lines, -8 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Jacob

lgtm http://codereview.chromium.org/9199002/diff/3001/client/html/src/NodeWrappingImplementation.dart File client/html/src/NodeWrappingImplementation.dart (right): http://codereview.chromium.org/9199002/diff/3001/client/html/src/NodeWrappingImplementation.dart#newcode165 client/html/src/NodeWrappingImplementation.dart:165: var nodes = <Node>[]; make this return a ...

8 years, 11 months ago (2012-01-17 18:14:53 UTC) #2

nweiz

8 years, 11 months ago (2012-01-17 23:23:21 UTC) #3

http://codereview.chromium.org/9199002/diff/3001/client/html/src/NodeWrapping...
File client/html/src/NodeWrappingImplementation.dart (right):

http://codereview.chromium.org/9199002/diff/3001/client/html/src/NodeWrapping...
client/html/src/NodeWrappingImplementation.dart:165: var nodes = <Node>[];
On 2012/01/17 18:14:53, Jacob wrote:
> make this return a Nodelist rather than a List so that jquery style chaining
can
> work in the future.

How will this work type-wise? The user only accesses these methods through the
List interface, which specifies List as the return value. Or will NodeList
override all these signatures?

Expand Messages | Collapse Messages

Issue 9199002: Support various range methods on NodeList. (Closed)

Description

Patch Set 1 #

Patch Set 2 : Merge with HEAD #

Messages