Support various range methods on NodeList.

client/html/src/NodeWrappingImplementation.dart

 // Copyright (c) 2011, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 class _ChildrenNodeList implements NodeList {
   // Raw node.
   final _node;
   final _childNodes;
 
   _ChildrenNodeList._wrap(var node)
@@ skipping 57 matching lines @@
 
   int get length() {
     return _childNodes.length;
   }
 
   Node operator [](int index) {
     return LevelDom.wrapNode(_childNodes[index]);
   }
 
   void operator []=(int index, Node value) {
-    _childNodes[index] = LevelDom.unwrap(value);
+    _node.replaceChild(LevelDom.unwrap(value), _childNodes[index]);
   }
 
    void set length(int newLength) {
      throw new UnsupportedOperationException('');
    }
 
   /** @domName Node.appendChild */
   Node add(Node value) {
     _node.appendChild(LevelDom.unwrap(value));
     return value;
@@ skipping 16 matching lines @@
 
   void sort(int compare(Node a, Node b)) {
     throw const UnsupportedOperationException('TODO(jacobr): should we impl?');
   }
 
   void copyFrom(List<Object> src, int srcStart, int dstStart, int count) {
     throw 'Not impl yet. todo(jacobr)';
   }
 
   void setRange(int start, int length, List from, [int startFrom = 0]) {
-    throw const NotImplementedException();
+    // TODO(nweiz): remove these IndexOutOfRange checks once Frog has bounds
+    // checking for List indexing
+    if (start < 0) {
+      throw new IndexOutOfRangeException(start);
+    } else if (startFrom < 0) {
+      throw new IndexOutOfRangeException(startFrom);
+    } else if (length < 0) {
+      throw new IllegalArgumentException("negative length $length");
+    } else if (start + length > this.length) {
+      throw new IndexOutOfRangeException(Math.min(this.length, start));
+    } else if (startFrom + length > from.length) {
+      throw new IndexOutOfRangeException(Math.min(from.length, startFrom));
+    }
+
+    for (var i = 0; i < length; i++) {
+      this[start + i] = from[startFrom + i];
+    }
   }
 
   void removeRange(int start, int length) {
-    throw const NotImplementedException();
+    // TODO(nweiz): remove these IndexOutOfRange checks once Frog has bounds
+    // checking for List indexing
+    if (start < 0) {
+      throw new IndexOutOfRangeException(start);
+    } else if (length < 0) {
+      throw new IllegalArgumentException("negative length $length");
+    } else if (start + length > this.length) {
+      throw new IndexOutOfRangeException(Math.min(this.length, start));
+    }
+
+    for (var i = 0; i < length; i++) {
+      this[start].remove();
+    }
   }
 
   void insertRange(int start, int length, [initialValue = null]) {
     throw const NotImplementedException();
   }
 
   List getRange(int start, int length) {
-    throw const NotImplementedException();
+    // TODO(nweiz): remove these IndexOutOfRange checks once Frog has bounds
+    // checking for List indexing
+    if (start < 0) {
+      throw new IndexOutOfRangeException(start);
+    } else if (length < 0) {
+      throw new IllegalArgumentException("negative length $length");
+    } else if (start + length > this.length) {
+      throw new IndexOutOfRangeException(Math.min(this.length, start));
+    }
+
+    var nodes = <Node>[];

[Jacob, 2012/01/17 18:14:53]

make this return a Nodelist rather than a List so that jquery style chaining can
work in the future.

[nweiz, 2012/01/17 23:23:22]

How will this work type-wise? The user only accesses these methods through the
List interface, which specifies List as the return value. Or will NodeList
override all these signatures?

+    for (var i = 0; i < length; i++) {
+      nodes.add(this[start + i]);
+    }
+    return nodes;
   }
 
   int indexOf(Node element, [int start = 0]) {
     return _Lists.indexOf(this, element, start, this.length);
   }
 
   int lastIndexOf(Node element, [int start = null]) {
     if (start === null) start = length - 1;
     return _Lists.lastIndexOf(this, element, start);
   }
@@ skipping 78 matching lines @@
   // array.
   Node insertBefore(Node newChild, Node refChild) {
     return LevelDom.wrapNode(_ptr.insertBefore(
         LevelDom.unwrap(newChild), LevelDom.unwrap(refChild)));
   }
 
   Node clone(bool deep) {
     return LevelDom.wrapNode(_ptr.cloneNode(deep));
   }
 }