Issue 9190060: Fix a dumb typo in SVGElementWrappingImplementation.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 9190060: Fix a dumb typo in SVGElementWrappingImplementation. (Closed)

Created:
8 years, 11 months ago by nweiz

Modified:
8 years, 11 months ago

Reviewers:
codefu, Jacob, zundel

CC:
reviews_dartlang.org, sra1, zundel

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Fix a dumb typo in SVGElementWrappingImplementation. TBR Committed: https://code.google.com/p/dart/source/detail?r=3255

Patch Set 1 #

Total comments: 2

Created: 8 years, 11 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+3 lines, -6 lines)			Patch
M	client/html/release/htmlimpl.dart	View	1 chunk	+1 line, -1 line	0 comments	Download
M	client/html/src/SVGElementWrappingImplementation.dart	View	1 chunk	+1 line, -1 line	0 comments	Download
M	tools/testing/dart/test_suite.dart	View	1 chunk	+1 line, -4 lines	2 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

zundel

http://codereview.chromium.org/9190060/diff/1/tools/testing/dart/test_suite.dart File tools/testing/dart/test_suite.dart (right): http://codereview.chromium.org/9190060/diff/1/tools/testing/dart/test_suite.dart#newcode734 tools/testing/dart/test_suite.dart:734: ['-check-only', '-fatal-type-errors', '-Werror', '-out', tempDir.path]; Could you put the ...

8 years, 11 months ago (2012-01-12 21:17:57 UTC) #2

codefu

8 years, 11 months ago (2012-01-12 21:22:05 UTC) #3

http://codereview.chromium.org/9190060/diff/1/tools/testing/dart/test_suite.dart
File tools/testing/dart/test_suite.dart (right):

http://codereview.chromium.org/9190060/diff/1/tools/testing/dart/test_suite.d...
tools/testing/dart/test_suite.dart:734: ['-check-only', '-fatal-type-errors',
'-Werror', '-out', tempDir.path];
On 2012/01/12 21:17:57, zundel wrote:
> Could you put the TODO back?

AND remove the -fatal-type-errors, -Werror which was removed.

Expand Messages | Collapse Messages