tools/testing/dart/test_suite.dart - Issue 9190060: Fix a dumb typo in SVGElementWrappingImplementation.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tools/testing/dart/test_suite.dart

Issue 9190060: Fix a dumb typo in SVGElementWrappingImplementation. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Patch Set: Created 8 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: tools/testing/dart/test_suite.dart

diff --git a/tools/testing/dart/test_suite.dart b/tools/testing/dart/test_suite.dart

index 6c5a4cf8bbc5b7824b1c40865c0f99a8fd81f5e2..9e8630d29054134f8bbe2827f2eea9347b9f1239 100644

--- a/tools/testing/dart/test_suite.dart

+++ b/tools/testing/dart/test_suite.dart

@@ -731,10 +731,7 @@ class DartcCompilationTestSuite extends StandardTestSuite {

var tempDir = new Directory('');

tempDir.createTempSync();

return

- [ // TODO(zundel): re-enable the --fatal-* flags as soon as warnings in

- // htmllib introduced by r3223 are resolved.

- // '--fatal-warnings', '--fatal-type-errors',

- '-check-only', '-out', tempDir.path];

+ ['-check-only', '-fatal-type-errors', '-Werror', '-out', tempDir.path];

zundel 2012/01/12 21:17:57 Could you put the TODO back?

codefu 2012/01/12 21:22:05 AND remove the -fatal-type-errors, -Werror which w

}

void processDirectory() {

« no previous file with comments | « client/html/src/SVGElementWrappingImplementation.dart ('k') | no next file » | no next file with comments »