Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(484)

Issue 9187064: Turn on fatal warnings for compiler tests in the 'dartc' tests again (Closed)

Created:
8 years, 11 months ago by zundel
Modified:
8 years, 11 months ago
Reviewers:
mmendez, codefu
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Turn on fatal warnings for compiler tests in the 'dartc' tests again BUG= TEST= Committed: https://code.google.com/p/dart/source/detail?r=3260

Patch Set 1 #

Patch Set 2 : Adds fatal-warnings flags to building the core libraries. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -2 lines) Patch
M compiler/dart-compiler.gyp View 1 1 chunk +3 lines, -1 line 0 comments Download
M tools/testing/dart/test_suite.dart View 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 3 (0 generated)
zundel
This will catch problems in the core library and other pre-build libraries sooner. On the ...
8 years, 11 months ago (2012-01-12 21:48:23 UTC) #1
codefu
lgtm
8 years, 11 months ago (2012-01-12 21:49:28 UTC) #2
mmendez
8 years, 11 months ago (2012-01-12 21:50:48 UTC) #3
On 2012/01/12 21:49:28, codefu wrote:
> lgtm

lgtm

Powered by Google App Engine
This is Rietveld 408576698