Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(86)

Side by Side Diff: tools/testing/dart/test_suite.dart

Issue 9187064: Turn on fatal warnings for compiler tests in the 'dartc' tests again (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Adds fatal-warnings flags to building the core libraries. Created 8 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « compiler/dart-compiler.gyp ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2011, the Dart project authors. Please see the AUTHORS file 1 // Copyright (c) 2011, the Dart project authors. Please see the AUTHORS file
2 // for details. All rights reserved. Use of this source code is governed by a 2 // for details. All rights reserved. Use of this source code is governed by a
3 // BSD-style license that can be found in the LICENSE file. 3 // BSD-style license that can be found in the LICENSE file.
4 4
5 #library("test_suite"); 5 #library("test_suite");
6 6
7 #import("status_file_parser.dart"); 7 #import("status_file_parser.dart");
8 #import("test_runner.dart"); 8 #import("test_runner.dart");
9 #import("multitest.dart"); 9 #import("multitest.dart");
10 10
(...skipping 713 matching lines...) Expand 10 before | Expand all | Expand 10 after
724 } 724 }
725 725
726 String shellPath() => TestUtils.compilerPath(configuration); 726 String shellPath() => TestUtils.compilerPath(configuration);
727 727
728 List<String> additionalOptions() { 728 List<String> additionalOptions() {
729 // TODO(ager): potentially register cleanup action to delete the temporary 729 // TODO(ager): potentially register cleanup action to delete the temporary
730 // directories? 730 // directories?
731 var tempDir = new Directory(''); 731 var tempDir = new Directory('');
732 tempDir.createTempSync(); 732 tempDir.createTempSync();
733 return 733 return
734 ['-check-only', '-fatal-type-errors', '-Werror', '-out', tempDir.path]; 734 [ '--fatal-warnings', '--fatal-type-errors',
735 '-check-only', '-out', tempDir.path];
735 } 736 }
736 737
737 void processDirectory() { 738 void processDirectory() {
738 directoryPath = getDirname(directoryPath); 739 directoryPath = getDirname(directoryPath);
739 // Enqueueing the directory listers is an activity. 740 // Enqueueing the directory listers is an activity.
740 activityStarted(); 741 activityStarted();
741 for (String testDir in _testDirs) { 742 for (String testDir in _testDirs) {
742 Directory dir = new Directory("$directoryPath/$testDir"); 743 Directory dir = new Directory("$directoryPath/$testDir");
743 if (dir.existsSync()) { 744 if (dir.existsSync()) {
744 activityStarted(); 745 activityStarted();
(...skipping 269 matching lines...) Expand 10 before | Expand all | Expand 10 after
1014 * $noCrash tests are expected to be flaky but not crash 1015 * $noCrash tests are expected to be flaky but not crash
1015 * $pass tests are expected to pass 1016 * $pass tests are expected to pass
1016 * $failOk tests are expected to fail that we won't fix 1017 * $failOk tests are expected to fail that we won't fix
1017 * $fail tests are expected to fail that we should fix 1018 * $fail tests are expected to fail that we should fix
1018 * $crash tests are expected to crash that we should fix 1019 * $crash tests are expected to crash that we should fix
1019 * $timeout tests are allowed to timeout 1020 * $timeout tests are allowed to timeout
1020 """; 1021 """;
1021 print(report); 1022 print(report);
1022 } 1023 }
1023 } 1024 }
OLDNEW
« no previous file with comments | « compiler/dart-compiler.gyp ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698