Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(302)

Issue 9168008: Enabled CSS tests, added CSS tests to buildbot, fixed tooling with nodejs, and added more tests. (Closed)

Created:
8 years, 11 months ago by terry
Modified:
8 years, 11 months ago
Reviewers:
Emily Fortuna
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Enabled CSS tests, added CSS tests to buildbot, fixed tooling with nodejs, and added more tests. BUG= TEST= Committed: https://code.google.com/p/dart/source/detail?r=3147

Patch Set 1 #

Patch Set 2 : Changes from CR #

Patch Set 3 : Changed to consistent coding convention for local variables in a for/loop. #

Patch Set 4 : More coding convention changes (consistency). #

Unified diffs Side-by-side diffs Delta from patch set Stats (+737 lines, -372 lines) Patch
M frog/scripts/buildbot_annotated_steps.py View 1 2 chunks +3 lines, -2 lines 0 comments Download
M utils/css/cssworld.dart View 1 2 2 chunks +2 lines, -2 lines 0 comments Download
M utils/css/generate.dart View 1 2 5 chunks +8 lines, -8 lines 0 comments Download
M utils/css/parser.dart View 1 2 5 chunks +21 lines, -9 lines 0 comments Download
M utils/css/tokenkind.dart View 1 2 4 chunks +6 lines, -6 lines 0 comments Download
M utils/css/tool.dart View 1 chunk +2 lines, -1 line 0 comments Download
M utils/css/tree.dart View 1 2 10 chunks +10 lines, -10 lines 0 comments Download
M utils/css/uitest.dart View 1 2 5 chunks +5 lines, -8 lines 0 comments Download
M utils/css/validate.dart View 1 2 7 chunks +15 lines, -11 lines 0 comments Download
M utils/tests/css/css.status View 1 chunk +2 lines, -1 line 0 comments Download
A utils/tests/css/src/DeclarationTest.dart View 1 chunk +256 lines, -0 lines 0 comments Download
M utils/tests/css/src/ExpressionTest.dart View 1 2 3 4 chunks +384 lines, -290 lines 0 comments Download
M utils/tests/css/src/SelectorLiteralTest.dart View 1 2 3 18 chunks +23 lines, -24 lines 0 comments Download

Messages

Total messages: 1 (0 generated)
Emily Fortuna
8 years, 11 months ago (2012-01-10 17:50:08 UTC) #1
lgtm

Powered by Google App Engine
This is Rietveld 408576698