Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(247)

Unified Diff: utils/css/uitest.dart

Issue 9168008: Enabled CSS tests, added CSS tests to buildbot, fixed tooling with nodejs, and added more tests. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: More coding convention changes (consistency). Created 8 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « utils/css/tree.dart ('k') | utils/css/validate.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: utils/css/uitest.dart
diff --git a/utils/css/uitest.dart b/utils/css/uitest.dart
index be0d0c31deda9b56390ce1511ffba0772f49e234..47a2d8457fb0228468ba711a4efa180f98eb90d1 100644
--- a/utils/css/uitest.dart
+++ b/utils/css/uitest.dart
@@ -2,9 +2,7 @@
// for details. All rights reserved. Use of this source code is governed by a
// BSD-style license that can be found in the LICENSE file.
-//#import('../file_system.dart');
-
-#import("dart:dom");
+#import('dart:dom');
#import('css.dart');
#import('../../frog/lang.dart', prefix:'lang');
#import('../../frog/file_system_memory.dart');
@@ -17,7 +15,7 @@ void runCss([bool debug = false, bool parseOnly = false]) {
List<String> knownWorld = classes.value.split("\n");
List<String> knownClasses = [];
List<String> knownIds = [];
- for (var name in knownWorld) {
+ for (final name in knownWorld) {
if (name.startsWith('.')) {
knownClasses.add(name.substring(1));
} else if (name.startsWith('#')) {
@@ -33,7 +31,7 @@ void runCss([bool debug = false, bool parseOnly = false]) {
if (!debug) {
try {
cssParseAndValidate(cssExpr, cssWorld);
- } catch (var cssException) {
+ } catch (final cssException) {
templateValid = false;
dumpTree = cssException.toString();
}
@@ -48,14 +46,14 @@ void runCss([bool debug = false, bool parseOnly = false]) {
stylesheetTree.add("\n============>Tree Dump<============\n");
stylesheetTree.add(stylesheet.toDebugString());
dumpTree = stylesheetTree.toString();
- } catch (var cssParseException) {
+ } catch (final cssParseException) {
templateValid = false;
dumpTree = cssParseException.toString();
}
} else {
try {
dumpTree = cssParseAndValidateDebug(cssExpr, cssWorld);
- } catch (var cssException) {
+ } catch (final cssException) {
templateValid = false;
dumpTree = cssException.toString();
}
@@ -95,7 +93,6 @@ void main() {
''';
document.body.appendChild(element);
-// document.body.elements.add(element);
// TODO(terry): Needed so runCss isn't shakened out.
if (false) {
« no previous file with comments | « utils/css/tree.dart ('k') | utils/css/validate.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698