Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3)

Issue 9151015: addressing 3 previous review comments (Closed)

Created:
8 years, 11 months ago by jimhug
Modified:
8 years, 11 months ago
Reviewers:
Jennifer Messerly
CC:
reviews_dartlang.org
Visibility:
Public.

Description

running presubmit review suggestions BUG= TEST= Committed: https://code.google.com/p/dart/source/detail?r=3114

Patch Set 1 #

Patch Set 2 : rebased #

Unified diffs Side-by-side diffs Delta from patch set Stats (+27 lines, -37 lines) Patch
M frog/gen.dart View 1 4 chunks +6 lines, -5 lines 0 comments Download
M frog/member.dart View 3 chunks +2 lines, -11 lines 0 comments Download
M frog/minfrog View 1 6 chunks +7 lines, -11 lines 0 comments Download
M frog/tokenizer.dart View 3 chunks +5 lines, -7 lines 0 comments Download
M frog/value.dart View 2 chunks +6 lines, -2 lines 0 comments Download
M tests/language/language.status View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 2 (0 generated)
jimhug
tbr - thanks for making me make the code better.
8 years, 11 months ago (2012-01-09 21:47:58 UTC) #1
Jennifer Messerly
8 years, 11 months ago (2012-01-10 00:19:37 UTC) #2
lgtm

Powered by Google App Engine
This is Rietveld 408576698