addressing 3 previous review comments

frog/minfrog

 #!/usr/bin/env node
 //  ********** Library dart:core **************
 //  ********** Natives dart:core **************
 function $throw(e) {
   // If e is not a value, we can use V8's captureStackTrace utility method.
   // TODO(jmesserly): capture the stack trace on other JS engines.
   if (e && (typeof e == 'object') && Error.captureStackTrace) {
     // TODO(jmesserly): this will clobber the e.stack property
     Error.captureStackTrace(e, $throw);
   }
@@ skipping 617 matching lines @@
   return this.some(to$call$1($0));
 }, enumerable: false, configurable: true });
 Object.defineProperty(ListFactory.prototype, "sort$1", { value: function($0) {
   return this.sort(to$call$2($0));
 }, enumerable: false, configurable: true });
 ListFactory_E = ListFactory;
 ListFactory_Expression = ListFactory;
 ListFactory_K = ListFactory;
 ListFactory_dart_core_String = ListFactory;
 ListFactory_V = ListFactory;
-ListFactory_Value = ListFactory;
 ListFactory_int = ListFactory;
 // ********** Code for ListIterator **************
 function ListIterator(array) {
   this._array = array;
   this._pos = (0);
 }
 ListIterator.prototype.hasNext = function() {
   return this._array.get$length() > this._pos;
 }
 ListIterator.prototype.next = function() {
@@ skipping 3554 matching lines @@
   }
   $globals.world.listFactoryType.markUsed();
   var ret = new ListValue(argValues, node.isConst, listType, node.span);
   if (ret.get$isConst()) return ret.getGlobalValue$0();
   return ret;
 }
 MethodGenerator.prototype.visitMapExpression = function(node) {
   if (node.items.get$length() == (0) && !node.isConst) {
     return $globals.world.mapType.getConstructor("").invoke$4(this, node, new Value.type$ctor($globals.world.mapType, node.span), Arguments.get$EMPTY());
   }
-  var values = new Array();
+  var values = [];
   var valueType = $globals.world.varType, keyType = $globals.world.stringType;
   var mapType = $globals.world.mapType;
   if (node.valueType != null) {
     if (node.keyType != null) {
       keyType = this.method.resolveType(node.keyType, true);
       if (!keyType.get$isString()) {
         $globals.world.error("the key type of a map literal must be \"String\"", keyType.get$span());
       }
       if (node.isConst && ((keyType instanceof ParameterType) || keyType.get$hasTypeParams())) {
         $globals.world.error("type parameter cannot be used in const map literals");
@@ skipping 2543 matching lines @@
   return this._finishToken(kind);
 }
 TokenizerBase.prototype._makeStringToken = function(buf, isPart) {
   var s = Strings.String$fromCharCodes$factory(buf);
   var kind = isPart ? (59) : (58);
   return new LiteralToken(kind, this._source, this._startIndex, this._lang_index, s);
 }
 TokenizerBase.prototype._makeRawStringToken = function(isMultiline) {
   var s;
   if (isMultiline) {
-    if (this._source.get$text()[this._startIndex + (4)] == "\n") {
-      s = this._source.get$text().substring(this._startIndex + (5), this._lang_index - (3));
-    }
-    else {
-      s = this._source.get$text().substring(this._startIndex + (4), this._lang_index - (3));
-    }
+    var start = this._startIndex + (4);
+    if (this._source.get$text()[start] == "\n") start++;
+    s = this._source.get$text().substring(start, this._lang_index - (3));
   }
   else {
     s = this._source.get$text().substring(this._startIndex + (2), this._lang_index - (1));
   }
   return new LiteralToken((58), this._source, this._startIndex, this._lang_index, s);
 }
 TokenizerBase.prototype.finishMultilineString = function(quote) {
-  var buf = new Array();
+  var buf = [];
   while (true) {
     var ch = this._nextChar();
     if (ch == (0)) {
       return this._errorToken();
     }
     else if (ch == quote) {
       if (this._maybeEatChar(quote)) {
         if (this._maybeEatChar(quote)) {
           return this._makeStringToken(buf, false);
         }
@@ skipping 49 matching lines @@
     }
   }
   return this.finishStringBody(quote);
 }
 TokenizerBase.prototype.finishRawString = function(quote) {
   if (this._maybeEatChar(quote)) {
     if (this._maybeEatChar(quote)) {
       return this.finishMultilineRawString(quote);
     }
     else {
-      return this._makeStringToken(new Array(), false);
+      return this._makeStringToken([], false);
     }
   }
   while (true) {
     var ch = this._nextChar();
     if (ch == quote) {
       return this._makeRawStringToken(false);
     }
     else if (ch == (0)) {
       return this._errorToken();
     }
@@ skipping 5480 matching lines @@
 Value.prototype.unop$3 = Value.prototype.unop;
 // ********** Code for EvaluatedValue **************
 $inherits(EvaluatedValue, Value);
 function EvaluatedValue(isConst, type, span) {
   this.isConst = isConst;
   Value.call(this, type, "@@@", span, false);
 }
 EvaluatedValue.prototype.get$isConst = function() { return this.isConst; };
 EvaluatedValue.prototype.set$isConst = function(value) { return this.isConst = value; };
 EvaluatedValue.prototype.get$code = function() {
-  return "@@@";
+  $globals.world.internalError("Should not be getting code from raw EvaluatedValue", this.span);
 }
 EvaluatedValue.prototype.hashCode = function() {
   return this.get$code().hashCode();
 }
 EvaluatedValue.prototype.$eq = function(other) {
   return (other instanceof EvaluatedValue) && $eq(other.get$type(), this.get$type()) && $eq(other.get$code(), this.get$code());
 }
 EvaluatedValue.prototype.hashCode$0 = EvaluatedValue.prototype.hashCode;
 // ********** Code for NullValue **************
 $inherits(NullValue, EvaluatedValue);
@@ skipping 1606 matching lines @@
   $globals._RED_COLOR = "\x1b[31m";
 }
 var const$0000 = Object.create(EmptyQueueException.prototype, {});
 var const$0001 = Object.create(_DeletedKeySentinel.prototype, {});
 var const$0005 = Object.create(NoMoreElementsException.prototype, {});
 var const$0007 = Object.create(IllegalAccessException.prototype, {});
 var const$0008 = ImmutableList.ImmutableList$from$factory([]);
 var $globals = {};
 $static_init();
 main();