Issue 9148048: Standardize error printing a bit by moving it to the Error object and

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 9148048: Standardize error printing a bit by moving it to the Error object and (Closed)

Created:
8 years, 11 months ago by turnidge

Modified:
8 years, 11 months ago

Reviewers:
cshapiro

CC:
reviews_dartlang.org, vm-dev_dartlang.org

Base URL:
http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Visibility:
Public.

More Reviews

Description

Standardize error printing a bit by moving it to the Error object and descendants. Committed: https://code.google.com/p/dart/source/detail?r=3219

Patch Set 2 : '' #

Created: 8 years, 11 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+97 lines, -88 lines)			Patch
M	runtime/lib/isolate.cc	View	1	6 chunks	+23 lines, -31 lines	0 comments	Download
M	runtime/vm/dart_api_impl.cc	View	1	1 chunk	+8 lines, -57 lines	0 comments	Download
M	runtime/vm/object.h	View	1	5 chunks	+11 lines, -0 lines	0 comments	Download
M	runtime/vm/object.cc	View	1	6 chunks	+55 lines, -0 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

cshapiro

LGTM http://codereview.chromium.org/9148048/diff/1/runtime/lib/isolate.cc File runtime/lib/isolate.cc (right): http://codereview.chromium.org/9148048/diff/1/runtime/lib/isolate.cc#newcode60 runtime/lib/isolate.cc:60: fprintf(stderr, "%s\n", error.ToErrorCString()); Why not use OS::PrintErr instead ...

8 years, 11 months ago (2012-01-12 00:37:39 UTC) #2

turnidge

8 years, 11 months ago (2012-01-12 19:15:39 UTC) #3

http://codereview.chromium.org/9148048/diff/1/runtime/lib/isolate.cc
File runtime/lib/isolate.cc (right):

http://codereview.chromium.org/9148048/diff/1/runtime/lib/isolate.cc#newcode60
runtime/lib/isolate.cc:60: fprintf(stderr, "%s\n", error.ToErrorCString());
On 2012/01/12 00:37:39, cshapiro wrote:
> Why not use OS::PrintErr instead of fprintf?

Done.

Expand Messages | Collapse Messages

Issue 9148048: Standardize error printing a bit by moving it to the Error object and (Closed)

Description

Patch Set 1 #

Patch Set 2 : '' #

Messages