Standardize error printing a bit by moving it to the Error object and

runtime/vm/object.cc

 // Copyright (c) 2011, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 #include "vm/object.h"
 
 #include "vm/assembler.h"
 #include "vm/assert.h"
 #include "vm/bigint_operations.h"
 #include "vm/bootstrap.h"
 #include "vm/code_generator.h"
 #include "vm/code_index_table.h"
 #include "vm/code_patcher.h"
 #include "vm/compiler.h"
 #include "vm/compiler_stats.h"
 #include "vm/class_finalizer.h"
 #include "vm/dart.h"
+#include "vm/dart_entry.h"
 #include "vm/debuginfo.h"
 #include "vm/exceptions.h"
 #include "vm/growable_array.h"
 #include "vm/heap.h"
 #include "vm/ic_data.h"
 #include "vm/object_store.h"
 #include "vm/parser.h"
 #include "vm/runtime_entry.h"
 #include "vm/scopes.h"
 #include "vm/timer.h"
@@ skipping 5001 matching lines @@
                                      intptr_t context_level) const {
   VariableDescAddr(scope_index)->context_level = Smi::New(context_level);
 }
 
 
 const char* ContextScope::ToCString() const {
   return "ContextScope";
 }
 
 
+const char* Error::ToErrorCString() const {
+  UNREACHABLE();
+  return "Internal Error";
+}
+
+
 const char* Error::ToCString() const {
   // Error is an abstract class.  We should never reach here.
   UNREACHABLE();
   return "Error";
 }
 
 
 RawApiError* ApiError::New(const String& message, Heap::Space space) {
   const Class& cls = Class::Handle(Object::api_error_class());
   ApiError& result = ApiError::Handle();
   {
     RawObject* raw = Object::Allocate(cls,
                                       ApiError::InstanceSize(),
                                       space);
     NoGCScope no_gc;
     result ^= raw;
   }
   result.set_message(message);
   return result.raw();
 }
 
 
 void ApiError::set_message(const String& message) const {
   StorePointer(&raw_ptr()->message_, message.raw());
 }
 
 
+const char* ApiError::ToErrorCString() const {
+  const String& msg_str = String::Handle(message());
+  return msg_str.ToCString();
+}
+
+
 const char* ApiError::ToCString() const {
   return "ApiError";
 }
 
 
 RawLanguageError* LanguageError::New(const String& message, Heap::Space space) {
   const Class& cls = Class::Handle(Object::language_error_class());
   LanguageError& result = LanguageError::Handle();
   {
     RawObject* raw = Object::Allocate(cls,
                                       LanguageError::InstanceSize(),
                                       space);
     NoGCScope no_gc;
     result ^= raw;
   }
   result.set_message(message);
   return result.raw();
 }
 
 
 void LanguageError::set_message(const String& message) const {
   StorePointer(&raw_ptr()->message_, message.raw());
 }
 
 
+const char* LanguageError::ToErrorCString() const {
+  const String& msg_str = String::Handle(message());
+  return msg_str.ToCString();
+}
+
+
 const char* LanguageError::ToCString() const {
   return "LanguageError";
 }
 
 
 RawUnhandledException* UnhandledException::New(const Instance& exception,
                                                const Instance& stacktrace,
                                                Heap::Space space) {
   const Class& cls = Class::Handle(Object::unhandled_exception_class());
   UnhandledException& result = UnhandledException::Handle();
@@ skipping 13 matching lines @@
 void UnhandledException::set_exception(const Instance& exception) const {
   StorePointer(&raw_ptr()->exception_, exception.raw());
 }
 
 
 void UnhandledException::set_stacktrace(const Instance& stacktrace) const {
   StorePointer(&raw_ptr()->stacktrace_, stacktrace.raw());
 }
 
 
+const char* UnhandledException::ToErrorCString() const {
+  Isolate* isolate = Isolate::Current();
+  HANDLESCOPE(isolate);
+  Object& strtmp = Object::Handle();
+
+  const Instance& exc = Instance::Handle(exception());
+  strtmp = DartLibraryCalls::ToString(exc);
+  const char* exc_str =
+      "<Received error while converting exception to string>";
+  if (!strtmp.IsError()) {
+    exc_str = strtmp.ToCString();
+  }
+  const Instance& stack = Instance::Handle(stacktrace());
+  strtmp = DartLibraryCalls::ToString(stack);
+  const char* stack_str =
+      "<Received error while converting stack trace to string>";
+  if (!strtmp.IsError()) {
+    stack_str = strtmp.ToCString();
+  }
+
+  const char* format = "Unhandled exception:\n%s\n%s";
+  int len = (strlen(exc_str) + strlen(stack_str) + strlen(format)
+             - 4    // Two '%s'
+             + 1);  // '\0'
+  char* chars = reinterpret_cast<char*>(isolate->current_zone()->Allocate(len));
+  OS::SNPrint(chars, len, format, exc_str, stack_str);
+  return chars;
+}
+
+
 const char* UnhandledException::ToCString() const {
   return "UnhandledException";
 }
 
 
 RawUnwindError* UnwindError::New(const String& message, Heap::Space space) {
   const Class& cls = Class::Handle(Object::unwind_error_class());
   UnwindError& result = UnwindError::Handle();
   {
     RawObject* raw = Object::Allocate(cls,
                                       UnwindError::InstanceSize(),
                                       space);
     NoGCScope no_gc;
     result ^= raw;
   }
   result.set_message(message);
   return result.raw();
 }
 
 
 void UnwindError::set_message(const String& message) const {
   StorePointer(&raw_ptr()->message_, message.raw());
 }
 
 
+const char* UnwindError::ToErrorCString() const {
+  UNIMPLEMENTED();
+  return "UnwindError";
+}
+
+
 const char* UnwindError::ToCString() const {
   return "UnwindError";
 }
 
 
 bool Instance::Equals(const Instance& other) const {
   if (this->raw() == other.raw()) {
     return true;  // "===".
   }
 
@@ skipping 2395 matching lines @@
   const String& str = String::Handle(pattern());
   const char* format = "JSRegExp: pattern=%s flags=%s";
   intptr_t len = OS::SNPrint(NULL, 0, format, str.ToCString(), Flags());
   char* chars = reinterpret_cast<char*>(
       Isolate::Current()->current_zone()->Allocate(len + 1));
   OS::SNPrint(chars, (len + 1), format, str.ToCString(), Flags());
   return chars;
 }
 
 }  // namespace dart