Issue 9146017: Fix FrozenElementList#forEach.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 9146017: Fix FrozenElementList#forEach. (Closed)

Created:
8 years, 11 months ago by nweiz

Modified:
8 years, 11 months ago

Reviewers:
Jacob

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Fix FrozenElementList#forEach. TBR Committed: https://code.google.com/p/dart/source/detail?r=3123

Patch Set 1 #

Total comments: 2

Created: 8 years, 11 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+30 lines, -28 lines)			Patch
	M	client/html/release/htmlimpl.dart	View		7 chunks	+27 lines, -26 lines	0 comments	Download
	M	client/html/src/ElementWrappingImplementation.dart	View		1 chunk	+3 lines, -2 lines	2 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Jacob

http://codereview.chromium.org/9146017/diff/1/client/html/src/ElementWrappingImplementation.dart File client/html/src/ElementWrappingImplementation.dart (right): http://codereview.chromium.org/9146017/diff/1/client/html/src/ElementWrappingImplementation.dart#newcode159 client/html/src/ElementWrappingImplementation.dart:159: for (var i = 0; i < length; i++) ...

8 years, 11 months ago (2012-01-10 00:46:19 UTC) #2

nweiz

8 years, 11 months ago (2012-01-10 01:32:51 UTC) #3

http://codereview.chromium.org/9146017/diff/1/client/html/src/ElementWrapping...
File client/html/src/ElementWrappingImplementation.dart (right):

http://codereview.chromium.org/9146017/diff/1/client/html/src/ElementWrapping...
client/html/src/ElementWrappingImplementation.dart:159: for (var i = 0; i <
length; i++) {
On 2012/01/10 00:46:19, Jacob wrote:
> var ==> int

That seems redundant...

Expand Messages | Collapse Messages