client/html/src/ElementWrappingImplementation.dart - Issue 9146017: Fix FrozenElementList#forEach.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: client/html/src/ElementWrappingImplementation.dart

Issue 9146017: Fix FrozenElementList#forEach. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Patch Set: Created 8 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: client/html/src/ElementWrappingImplementation.dart

diff --git a/client/html/src/ElementWrappingImplementation.dart b/client/html/src/ElementWrappingImplementation.dart

index eded46deee989ca02a5eb8276d0c147ce3230fe9..64d521f74b04180e64686b777b746d17abfb640b 100644

--- a/client/html/src/ElementWrappingImplementation.dart

+++ b/client/html/src/ElementWrappingImplementation.dart

@@ -155,8 +155,9 @@ class FrozenElementList implements ElementList {

}

void forEach(void f(Element element)) {

- for (var element in _ptr) {

- f(LevelDom.wrapElement(element));

+ final length = _ptr.length;

+ for (var i = 0; i < length; i++) {

Jacob 2012/01/10 00:46:19 var ==> int

nweiz 2012/01/10 01:32:51 That seems redundant...

+ f(LevelDom.wrapElement(_ptr[i]));

}

« no previous file with comments | « client/html/release/htmlimpl.dart ('k') | no next file » | no next file with comments »