Issue 9120004: Fix assertion failure in Process object, where non-integer pid could be passed to kill.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 9120004: Fix assertion failure in Process object, where non-integer pid could be passed to kill. (Closed)

Created:
8 years, 11 months ago by Bill Hesse

Modified:
8 years, 11 months ago

Reviewers:
Søren Gjesse

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Fix assertion failure in Process object, where non-integer pid could be passed to kill. BUG= TEST= Committed: https://code.google.com/p/dart/source/detail?r=3038

Patch Set 1 #

Total comments: 1

Created: 8 years, 11 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+4 lines, -2 lines)			Patch
	M	runtime/bin/process_impl.dart	View		1 chunk	+4 lines, -2 lines	1 comment	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Søren Gjesse

8 years, 11 months ago (2012-01-06 13:43:20 UTC) #2

lgtm

http://codereview.chromium.org/9120004/diff/1/runtime/bin/process_impl.dart
File runtime/bin/process_impl.dart (right):

http://codereview.chromium.org/9120004/diff/1/runtime/bin/process_impl.dart#n...
runtime/bin/process_impl.dart:154: if (_closed && _pid === null) {
So we cannot ever have !_closed and _pid == null?

Expand Messages | Collapse Messages