runtime/bin/process_impl.dart - Issue 9120004: Fix assertion failure in Process object, where non-integer pid could be passed to kill.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: runtime/bin/process_impl.dart

Issue 9120004: Fix assertion failure in Process object, where non-integer pid could be passed to kill. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Patch Set: Created 8 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: runtime/bin/process_impl.dart

diff --git a/runtime/bin/process_impl.dart b/runtime/bin/process_impl.dart

index 86666700ec3b5b44d964b86d3a4bbdcfdbe947a4..dc1f94524fc08f3e1187abd2d6e3621e7b108425 100644

--- a/runtime/bin/process_impl.dart

+++ b/runtime/bin/process_impl.dart

@@ -151,8 +151,10 @@ class _Process implements Process {

}

void kill() {

- if (_closed && _pid === null && _errorHandler !== null) {

- _errorHandler(new ProcessException("Process closed"));

+ if (_closed && _pid === null) {

Søren Gjesse 2012/01/06 13:43:20 So we cannot ever have !_closed and _pid == null?

+ if (_errorHandler !== null) {

+ _errorHandler(new ProcessException("Process closed"));

+ }

return;

}

if (_killed) {

« no previous file with comments | « no previous file | no next file » | no next file with comments »