Thread pool changes

Thread pool changes

Make one global thread pool instead of a thread pool for each
eventhandler (i.e. isolate).

Also:

* Added handler function for thread pool tasks.
* Added thread pool shutdown.
* Added a simple test.

R=ager@google.com

BUG=
TEST=

Committed: https://code.google.com/p/dart/source/detail?r=3079

[Mads Ager (google), 2012-01-06 10:15:18]

Could you upload the test as well?

http://codereview.chromium.org/9112013/diff/1/runtime/bin/thread_pool.h
File runtime/bin/thread_pool.h (right):

http://codereview.chromium.org/9112013/diff/1/runtime/bin/thread_pool.h#newco...
runtime/bin/thread_pool.h:77: void* (*task_handler_)(void* args);
Let's typedef this type and the use a named type in the constructor as well as
here?

[Søren Gjesse, 2012-01-06 10:41:15]

Added test file as well.

http://codereview.chromium.org/9112013/diff/1/runtime/bin/thread_pool.h
File runtime/bin/thread_pool.h (right):

http://codereview.chromium.org/9112013/diff/1/runtime/bin/thread_pool.h#newco...
runtime/bin/thread_pool.h:77: void* (*task_handler_)(void* args);
On 2012/01/06 10:15:18, Mads Ager wrote:
> Let's typedef this type and the use a named type in the constructor as well as
> here?

Sure - looks nicer.

[Mads Ager (google), 2012-01-06 10:56:18]

lgtm

http://codereview.chromium.org/9112013/diff/7001/runtime/bin/thread_pool.h
File runtime/bin/thread_pool.h (right):

http://codereview.chromium.org/9112013/diff/7001/runtime/bin/thread_pool.h#ne...
runtime/bin/thread_pool.h:60: typedef void* (*ThreadPoolTaskHandler)(void*
args);
Does the style guide say anything about the placement of these. Should we move
this to the top with the Task typedef or should we declare it here closer to the
use? I have no strong personal preferences.

[Søren Gjesse, 2012-01-06 11:24:26]

http://codereview.chromium.org/9112013/diff/7001/runtime/bin/thread_pool.h
File runtime/bin/thread_pool.h (right):

http://codereview.chromium.org/9112013/diff/7001/runtime/bin/thread_pool.h#ne...
runtime/bin/thread_pool.h:60: typedef void* (*ThreadPoolTaskHandler)(void*
args);
On 2012/01/06 10:56:18, Mads Ager wrote:
> Does the style guide say anything about the placement of these. Should we move
> this to the top with the Task typedef or should we declare it here closer to
the
> use? I have no strong personal preferences. 

I moved it into class ThreadPool (and changed the name to TaskHandler) so that
it is now ThreadPool::TaskHandler. The style guide specifies the order inside a
class - typedefs and enums first.

[Søren Gjesse, 2012-01-06 14:07:23]

PTAL

I had to implement thread pool shutdown for the simple test. Without proper
shutdown it could potentially crash.

[Mads Ager (google), 2012-01-06 14:34:18]

lgtm