Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1708)

Issue 9112013: Thread pool changes (Closed)

Created:
8 years, 11 months ago by Søren Gjesse
Modified:
8 years, 11 months ago
Reviewers:
Mads Ager (google)
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Thread pool changes Make one global thread pool instead of a thread pool for each eventhandler (i.e. isolate). Also: * Added handler function for thread pool tasks. * Added thread pool shutdown. * Added a simple test. R=ager@google.com BUG= TEST= Committed: https://code.google.com/p/dart/source/detail?r=3079

Patch Set 1 #

Total comments: 2

Patch Set 2 : Added test file #

Patch Set 3 : Addressed review comments from ager@ #

Total comments: 2

Patch Set 4 : Added tread pool shutdown #

Unified diffs Side-by-side diffs Delta from patch set Stats (+141 lines, -29 lines) Patch
M runtime/bin/builtin_sources.gypi View 1 2 3 1 chunk +1 line, -0 lines 0 comments Download
M runtime/bin/eventhandler.h View 1 2 3 3 chunks +25 lines, -0 lines 0 comments Download
M runtime/bin/eventhandler.cc View 1 chunk +1 line, -0 lines 0 comments Download
M runtime/bin/eventhandler_linux.h View 1 chunk +0 lines, -1 line 0 comments Download
M runtime/bin/eventhandler_linux.cc View 1 chunk +0 lines, -7 lines 0 comments Download
M runtime/bin/main.cc View 1 2 3 3 chunks +7 lines, -0 lines 0 comments Download
M runtime/bin/thread_pool.h View 1 2 3 4 chunks +14 lines, -3 lines 0 comments Download
M runtime/bin/thread_pool.cc View 1 2 3 2 chunks +6 lines, -12 lines 0 comments Download
M runtime/bin/thread_pool_linux.cc View 1 2 3 4 chunks +27 lines, -2 lines 0 comments Download
M runtime/bin/thread_pool_macos.cc View 1 2 3 4 chunks +27 lines, -2 lines 0 comments Download
A runtime/bin/thread_pool_test.cc View 1 2 3 1 chunk +19 lines, -0 lines 0 comments Download
M runtime/bin/thread_pool_win.cc View 1 2 3 3 chunks +11 lines, -1 line 0 comments Download
M runtime/tests/vm/vm.status View 1 2 3 1 chunk +3 lines, -1 line 0 comments Download

Messages

Total messages: 7 (0 generated)
Søren Gjesse
8 years, 11 months ago (2012-01-05 16:12:35 UTC) #1
Mads Ager (google)
Could you upload the test as well? http://codereview.chromium.org/9112013/diff/1/runtime/bin/thread_pool.h File runtime/bin/thread_pool.h (right): http://codereview.chromium.org/9112013/diff/1/runtime/bin/thread_pool.h#newcode77 runtime/bin/thread_pool.h:77: void* (*task_handler_)(void* ...
8 years, 11 months ago (2012-01-06 10:15:18 UTC) #2
Søren Gjesse
Added test file as well. http://codereview.chromium.org/9112013/diff/1/runtime/bin/thread_pool.h File runtime/bin/thread_pool.h (right): http://codereview.chromium.org/9112013/diff/1/runtime/bin/thread_pool.h#newcode77 runtime/bin/thread_pool.h:77: void* (*task_handler_)(void* args); On ...
8 years, 11 months ago (2012-01-06 10:41:15 UTC) #3
Mads Ager (google)
lgtm http://codereview.chromium.org/9112013/diff/7001/runtime/bin/thread_pool.h File runtime/bin/thread_pool.h (right): http://codereview.chromium.org/9112013/diff/7001/runtime/bin/thread_pool.h#newcode60 runtime/bin/thread_pool.h:60: typedef void* (*ThreadPoolTaskHandler)(void* args); Does the style guide ...
8 years, 11 months ago (2012-01-06 10:56:18 UTC) #4
Søren Gjesse
http://codereview.chromium.org/9112013/diff/7001/runtime/bin/thread_pool.h File runtime/bin/thread_pool.h (right): http://codereview.chromium.org/9112013/diff/7001/runtime/bin/thread_pool.h#newcode60 runtime/bin/thread_pool.h:60: typedef void* (*ThreadPoolTaskHandler)(void* args); On 2012/01/06 10:56:18, Mads Ager ...
8 years, 11 months ago (2012-01-06 11:24:26 UTC) #5
Søren Gjesse
PTAL I had to implement thread pool shutdown for the simple test. Without proper shutdown ...
8 years, 11 months ago (2012-01-06 14:07:23 UTC) #6
Mads Ager (google)
8 years, 11 months ago (2012-01-06 14:34:18 UTC) #7
lgtm

Powered by Google App Engine
This is Rietveld 408576698