Thread pool changes

runtime/bin/thread_pool.h

 // Copyright (c) 2012, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 #ifndef BIN_THREAD_POOL_H_
 #define BIN_THREAD_POOL_H_
 
 #include "bin/builtin.h"
 #include "bin/globals.h"
 
 // Declare the OS-specific types ahead of defining the generic classes.
 #if defined(TARGET_OS_LINUX)
 #include "bin/thread_pool_linux.h"
 #elif defined(TARGET_OS_MACOS)
 #include "bin/thread_pool_macos.h"
 #elif defined(TARGET_OS_WINDOWS)
 #include "bin/thread_pool_win.h"
 #else
 #error Unknown target os.
 #endif
 
 
-typedef int Task;
+typedef void* Task;
 
 
 class TaskQueueEntry {
  public:
   explicit TaskQueueEntry(Task task) : task_(task), next_(NULL) {}
 
   Task task() { return task_; }
 
   TaskQueueEntry* next() { return next_; }
   void set_next(TaskQueueEntry* value) { next_ = value; }
@@ skipping 16 matching lines @@
 
  private:
   TaskQueueEntry* head_;
   TaskQueueEntry* tail_;
   TaskQueueData data_;
 
   DISALLOW_COPY_AND_ASSIGN(TaskQueue);
 };
 
 
+typedef void* (*ThreadPoolTaskHandler)(void* args);

[Mads Ager (google), 2012/01/06 10:56:18]

Does the style guide say anything about the placement of these. Should we move
this to the top with the Task typedef or should we declare it here closer to the
use? I have no strong personal preferences. 

[Søren Gjesse, 2012/01/06 11:24:26]

I moved it into class ThreadPool (and changed the name to TaskHandler) so that
it is now ThreadPool::TaskHandler. The style guide specifies the order inside a
class - typedefs and enums first.

+
+
 class ThreadPool {
  public:
-  explicit ThreadPool(int initial_size = 4) : size_(initial_size) {}
+  ThreadPool(ThreadPoolTaskHandler task_handler, int initial_size = 4)
+      : size_(initial_size), task_handler_(task_handler) {}
 
   void Start();
   void Shutdown();
 
   void InsertTask(Task task);
 
  private:
   Task WaitForTask();
 
   static void* Main(void* args);
 
   TaskQueue queue;
   int size_;  // Number of threads.
+  ThreadPoolTaskHandler task_handler_;
   ThreadPoolData data_;
 
   DISALLOW_COPY_AND_ASSIGN(ThreadPool);
 };
 
 #endif  // BIN_THREAD_POOL_H_