Issue 9112011: Add standard options to test.dart browser tests compilation command.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 9112011: Add standard options to test.dart browser tests compilation command. (Closed)

Created:
8 years, 11 months ago by Bill Hesse

Modified:
8 years, 11 months ago

Reviewers:
Mads Ager (google)

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Add standard options to test.dart browser tests compilation command. BUG= TEST=tools/test.dart -cfrogium --checked client/html Committed: https://code.google.com/p/dart/source/detail?r=2999

Patch Set 1 #

Created: 8 years, 11 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+5 lines, -5 lines)			Patch
	M	tools/testing/dart/test_suite.dart	View		2 chunks	+5 lines, -5 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Mads Ager (google)

LGTM I think we need more options on the run command as well in the ...

8 years, 11 months ago (2012-01-05 15:16:43 UTC) #2

Bill Hesse

8 years, 11 months ago (2012-01-05 15:24:23 UTC) #3

On 2012/01/05 15:16:43, Mads Ager wrote:
> LGTM
> 
> I think we need more options on the run command as well in the checked mode
> case.

The --dart-flags="..." option is present on all test.py compiler tests, but only
on test.dart dartium tests, because the flag is meaningless except on dartium
tests, so I put a (component == 'dartium') guard on the code that adds it.

Expand Messages | Collapse Messages