Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5)

Unified Diff: tools/testing/dart/test_suite.dart

Issue 9112011: Add standard options to test.dart browser tests compilation command. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Created 8 years, 12 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/testing/dart/test_suite.dart
diff --git a/tools/testing/dart/test_suite.dart b/tools/testing/dart/test_suite.dart
index 1ee3e1221d80d22003fb0e7669133fc13a802792..906731d5436dde8aa9c4e0f22395892ec9995e01 100644
--- a/tools/testing/dart/test_suite.dart
+++ b/tools/testing/dart/test_suite.dart
@@ -409,11 +409,11 @@ class StandardTestSuite implements TestSuite {
htmlTest.closeSync();
for (var vmOptions in optionsFromFile['vmOptions']) {
- List<String> compilerArgs;
+ List<String> compilerArgs = TestUtils.standardOptions(configuration);
String compilerExecutable = TestUtils.compilerPath(configuration);
switch (component) {
case 'chromium':
- compilerArgs = ['--work', tempDir.path];
+ compilerArgs.addAll(['--work', tempDir.path]);
if (configuration['mode'] == 'release') {
compilerArgs.add('--optimize');
}
@@ -425,9 +425,9 @@ class StandardTestSuite implements TestSuite {
// TODO(whesse): Add --fatal-type-errors if needed.
break;
case 'frogium':
- compilerArgs = ['--libdir=$dartDir/frog/lib',
- '--compile-only',
- '--out=$compiledDartWrapperFilename'];
+ compilerArgs.addAll(['--libdir=$dartDir/frog/lib',
+ '--compile-only',
+ '--out=$compiledDartWrapperFilename']);
compilerArgs.addAll(vmOptions);
compilerArgs.add(dartWrapperFilename);
break;
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698