Issue 9110031: Enable webdriver component in test.dart

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 9110031: Enable webdriver component in test.dart (Closed)

Created:
8 years, 11 months ago by Bill Hesse

Modified:
8 years, 11 months ago

Reviewers:
Emily Fortuna

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Enable webdriver component in test.dart BUG=dart:1046 TEST=tools/test.dart -cwebdriver Committed: https://code.google.com/p/dart/source/detail?r=3082

Patch Set 1 #

Total comments: 3

Created: 8 years, 11 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+56 lines, -18 lines)			Patch
M	tools/testing/dart/test_options.dart	View	4 chunks	+15 lines, -7 lines	0 comments	Download
M	tools/testing/dart/test_runner.dart	View	1 chunk	+1 line, -1 line	0 comments	Download
M	tools/testing/dart/test_suite.dart	View	5 chunks	+40 lines, -10 lines	3 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Bill Hesse

http://codereview.chromium.org/9110031/diff/1/tools/testing/dart/test_suite.dart File tools/testing/dart/test_suite.dart (right): http://codereview.chromium.org/9110031/diff/1/tools/testing/dart/test_suite.dart#newcode451 tools/testing/dart/test_suite.dart:451: for (var flag in configuration['flag'].split(',')) { Note: we could ...

8 years, 11 months ago (2012-01-06 13:39:09 UTC) #1

Emily Fortuna

8 years, 11 months ago (2012-01-08 18:47:06 UTC) #2

lgtm! Sorry for the delay.

http://codereview.chromium.org/9110031/diff/1/tools/testing/dart/test_suite.dart
File tools/testing/dart/test_suite.dart (right):

http://codereview.chromium.org/9110031/diff/1/tools/testing/dart/test_suite.d...
tools/testing/dart/test_suite.dart:451: for (var flag in
configuration['flag'].split(',')) {
You mean potentially list multiple browsers when calling test.dart? 
This seems good as it is. I wouldn't worry about that use case -- since I'm
doing performance testing, I run them individually.

On 2012/01/06 13:39:09, Bill Hesse wrote:
> Note: we could split configurations with commas in --flag value, so multiple
> runs with different browsers would work, but I don't think it is a good idea,
> especially if we want frog and frog-lib values in --flag as well.

Expand Messages | Collapse Messages