Enable webdriver component in test.dart

tools/testing/dart/test_suite.dart

Index: tools/testing/dart/test_suite.dart
diff --git a/tools/testing/dart/test_suite.dart b/tools/testing/dart/test_suite.dart
index 906731d5436dde8aa9c4e0f22395892ec9995e01..ebb17ec90fffc48cada2bea9d8edafafe805c35f 100644
--- a/tools/testing/dart/test_suite.dart
+++ b/tools/testing/dart/test_suite.dart
@@ -268,8 +268,9 @@ class StandardTestSuite implements TestSuite {
       case 'dartium':
       case 'chromium':
       case 'frogium':
-          enqueueBrowserTest(filename, testName, optionsFromFile,
-                             expectations, isNegative);
+      case 'webdriver':
+        enqueueBrowserTest(filename, testName, optionsFromFile,
+                           expectations, isNegative);
         break;
       default:
         // Only dartc supports fatal type errors. Enable fatal type
@@ -425,6 +426,7 @@ class StandardTestSuite implements TestSuite {
           // TODO(whesse): Add --fatal-type-errors if needed.
           break;
         case 'frogium':
+        case 'webdriver':
           compilerArgs.addAll(['--libdir=$dartDir/frog/lib',
                                '--compile-only',
                                '--out=$compiledDartWrapperFilename']);
@@ -440,20 +442,46 @@ class StandardTestSuite implements TestSuite {
           Expect.fail('unimplemented component $component');
       }
 
-      var args = ['--no-timeout'];
-      if (component == 'dartium') {
-        var dartFlags = ['--enable_asserts', '--enable_type_checks'];
-        dartFlags.addAll(vmOptions);
-        args.add('--dart-flags=${Strings.join(dartFlags, " ")}');
+      String executable = getFilename(dumpRenderTreeFilename);
+      List<String> args;
+      if (component == 'webdriver') {
+        executable = '$dartDir/tools/testing/run_selenium.py';
+        String browserFlag = 'chrome';
+        if (configuration['flag'] != null) {
+          for (var flag in configuration['flag'].split(',')) {

[Bill Hesse, 2012/01/06 13:39:09]

Note: we could split configurations with commas in --flag value, so multiple
runs with different browsers would work, but I don't think it is a good idea,
especially if we want frog and frog-lib values in --flag as well.

[Emily Fortuna, 2012/01/08 18:47:06]

You mean potentially list multiple browsers when calling test.dart? 
This seems good as it is. I wouldn't worry about that use case -- since I'm
doing performance testing, I run them individually.

On 2012/01/06 13:39:09, Bill Hesse wrote:

+            switch (flag) {
+              case 'ff':
+              case 'firefox':
+                browserFlag = 'ff';
+                break;
+              case 'ie':
+              case 'explorer':
+              case 'internet-explorer':
+                browserFlag = 'ie';
+                break;
+              case 'safari':
+                browserFlag = 'safari';
+                break;
+            }
+          }
+        }
+        args = ['--out', htmlPath, '--browser', browserFlag];
+        
+      } else {

[Bill Hesse, 2012/01/06 13:39:09]

Move dumpRenderTree value for executable here?

+        args = ['--no-timeout'];
+        if (component == 'dartium') {
+          var dartFlags = ['--enable_asserts', '--enable_type_checks'];
+          dartFlags.addAll(vmOptions);
+          args.add('--dart-flags=${Strings.join(dartFlags, " ")}');
+        }
+        args.add(htmlPath);
       }
-      args.add(htmlPath);
-
       // Create BrowserTestCase and queue it.
       var testCase = new BrowserTestCase(
           testName,
           compilerExecutable,
           compilerArgs,
-          getFilename(dumpRenderTreeFilename),
+          executable,
           args,
           configuration,
           completeHandler,
@@ -503,6 +531,7 @@ class StandardTestSuite implements TestSuite {
         return 'application/dart';
       case 'chromium':
       case 'frogium':
+      case 'webdriver':
         return 'text/javascript';
       default:
         Expect.fail('Unimplemented component scriptType');
@@ -858,6 +887,7 @@ class TestUtils {
       case 'dartc':
         return 'compiler/bin/dartc$postfix';
       case 'frogium':
+      case 'webdriver':
         return 'frog/bin/frogsh$postfix';
       default:
         throw "Unknown compiler for: ${configuration['component']}";