Issue 9107018: test.dart: a small fix to handle flakyness with DumpRenderTree and xvfb

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 9107018: test.dart: a small fix to handle flakyness with DumpRenderTree and xvfb (Closed)

Created:
8 years, 11 months ago by Siggi Cherem (dart-lang)

Modified:
8 years, 11 months ago

Reviewers:
Bill Hesse, Emily Fortuna

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

test.dart: a small fix to handle flakyness with DumpRenderTree and xvfb BUG= TEST= Committed: https://code.google.com/p/dart/source/detail?r=3210

Patch Set 1 #

Created: 8 years, 11 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+6 lines, -3 lines)			Patch
	M	tools/testing/dart/test_runner.dart	View		1 chunk	+6 lines, -3 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Bill Hesse

8 years, 11 months ago (2012-01-12 11:46:20 UTC) #3

Doesn't work for tests marked as failing in the status files (they generate an
unexpected pass).
It does work for Negative tests.
Updated the bug - I can fix this, with lower priority.

On 2012/01/11 21:55:00, Emily Fortuna wrote:
> good catch! 
> lgtm.

Expand Messages | Collapse Messages