Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(247)

Unified Diff: tools/testing/dart/test_runner.dart

Issue 9107018: test.dart: a small fix to handle flakyness with DumpRenderTree and xvfb (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Created 8 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/testing/dart/test_runner.dart
diff --git a/tools/testing/dart/test_runner.dart b/tools/testing/dart/test_runner.dart
index 3db97e59ecf58ee6f963e18c9208c16d6a3db912..8808912286dafdce739ef42d2890d6888d1914d4 100644
--- a/tools/testing/dart/test_runner.dart
+++ b/tools/testing/dart/test_runner.dart
@@ -161,14 +161,17 @@ class TestOutput {
if (line == 'PASS' && previous_line == 'Content-Type: text/plain') {
return (exitCode != 0 && !hasCrashed);
}
- // If the browser test failed, it may have been because DumpRenderTree
- // and the virtual framebuffer X server didn't hook up.
+ previous_line = line;
+ }
+
+ // If the browser test failed, it may have been because DumpRenderTree
+ // and the virtual framebuffer X server didn't hook up.
+ for (String line in stderr) {
if (line.contains('Gtk-WARNING **: cannot open display: :99')) {
// If we get the X server error, return the expected value
// We cannot restart the test from here. Issue dart:1135 is filed.
return testCase.isNegative;
}
- previous_line = line;
}
return true;
}
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698