Add close to input stream and cleanup socket and streams

Add close to input stream and cleanup socket and streams

* All input streams now have a close method for just cutting
  the stream
* Removed interfaces FileInputStream and FileOutputStream
* Added exceptions to socket to avoid mixing stream and non-stream
  use of the same socket
* Added special handling of the socket connect handler callback

R=ager@google.com

BUG=
TEST=

Committed: https://code.google.com/p/dart/source/detail?r=2893

[Mads Ager (google), 2011-12-23 08:35:39]

LGTM with a couple of comments.

http://codereview.chromium.org/9029001/diff/1/runtime/bin/eventhandler_linux.h
File runtime/bin/eventhandler_linux.h (right):

http://codereview.chromium.org/9029001/diff/1/runtime/bin/eventhandler_linux....
runtime/bin/eventhandler_linux.h:63: ASSERT(fd_ -1);
Looks like you never finished this? What do you want to assert here, that fd_ !=
-1?

http://codereview.chromium.org/9029001/diff/1/runtime/bin/input_stream.dart
File runtime/bin/input_stream.dart (right):

http://codereview.chromium.org/9029001/diff/1/runtime/bin/input_stream.dart#n...
runtime/bin/input_stream.dart:71: * more data. In normal situations where all
data is read from the
A couple of commas would help me read this:

In normal situations, where ... called, calling [close] is not required.

http://codereview.chromium.org/9029001/diff/1/runtime/bin/list_stream.dart
File runtime/bin/list_stream.dart (right):

http://codereview.chromium.org/9029001/diff/1/runtime/bin/list_stream.dart#ne...
runtime/bin/list_stream.dart:35: bool _closeCalled = false;
Is this ever used?

http://codereview.chromium.org/9029001/diff/1/runtime/bin/list_stream.dart#ne...
runtime/bin/list_stream.dart:46: if (_streamMarkedClosed || _closeCalled) {
I think you can get rid of _closeCalled here as well (and the declaration of it
below).

http://codereview.chromium.org/9029001/diff/1/runtime/bin/socket_impl.dart
File runtime/bin/socket_impl.dart (right):

http://codereview.chromium.org/9029001/diff/1/runtime/bin/socket_impl.dart#ne...
runtime/bin/socket_impl.dart:355: if (_outputStream != null) throw new
StreamException("Illegal state");
An error message that gave the programmer more help figuring out what is wrong
would be nice for all of these 'illegal state' exceptions.

http://codereview.chromium.org/9029001/diff/1/runtime/bin/socket_impl.dart#ne...
runtime/bin/socket_impl.dart:422: if (_clientWriteHandler === null)
_writeHandler = null;
Can't we just unconditionally do '_writeHandler = _clientWriteHandler' here? No
reason the keep checking for the first out event when we have just received it?

Maybe we should even move that to the first line of writeHandler before the
check on first out event. Once writeHandler has been called once there is no
need to check for first out event again?

http://codereview.chromium.org/9029001/diff/1/tests/standalone/src/FileTest.dart
File tests/standalone/src/FileTest.dart (right):

http://codereview.chromium.org/9029001/diff/1/tests/standalone/src/FileTest.d...
tests/standalone/src/FileTest.dart:80: //input.close();
Code in comment.

[Søren Gjesse, 2012-01-02 11:51:17]

http://codereview.chromium.org/9029001/diff/1/runtime/bin/eventhandler_linux.h
File runtime/bin/eventhandler_linux.h (right):

http://codereview.chromium.org/9029001/diff/1/runtime/bin/eventhandler_linux....
runtime/bin/eventhandler_linux.h:63: ASSERT(fd_ -1);
On 2011/12/23 08:35:40, Mads Ager wrote:
> Looks like you never finished this? What do you want to assert here, that fd_
!=
> -1?

ASSERT(fd_ != -1)

http://codereview.chromium.org/9029001/diff/1/runtime/bin/input_stream.dart
File runtime/bin/input_stream.dart (right):

http://codereview.chromium.org/9029001/diff/1/runtime/bin/input_stream.dart#n...
runtime/bin/input_stream.dart:71: * more data. In normal situations where all
data is read from the
On 2011/12/23 08:35:40, Mads Ager wrote:
> A couple of commas would help me read this:
> 
> In normal situations, where ... called, calling [close] is not required.

Done.

http://codereview.chromium.org/9029001/diff/1/runtime/bin/list_stream.dart
File runtime/bin/list_stream.dart (right):

http://codereview.chromium.org/9029001/diff/1/runtime/bin/list_stream.dart#ne...
runtime/bin/list_stream.dart:35: bool _closeCalled = false;
On 2011/12/23 08:35:40, Mads Ager wrote:
> Is this ever used?

No, removed.

http://codereview.chromium.org/9029001/diff/1/runtime/bin/list_stream.dart#ne...
runtime/bin/list_stream.dart:46: if (_streamMarkedClosed || _closeCalled) {
On 2011/12/23 08:35:40, Mads Ager wrote:
> I think you can get rid of _closeCalled here as well (and the declaration of
it
> below).

Done.

http://codereview.chromium.org/9029001/diff/1/runtime/bin/socket_impl.dart
File runtime/bin/socket_impl.dart (right):

http://codereview.chromium.org/9029001/diff/1/runtime/bin/socket_impl.dart#ne...
runtime/bin/socket_impl.dart:355: if (_outputStream != null) throw new
StreamException("Illegal state");
On 2011/12/23 08:35:40, Mads Ager wrote:
> An error message that gave the programmer more help figuring out what is wrong
> would be nice for all of these 'illegal state' exceptions.

Done.

http://codereview.chromium.org/9029001/diff/1/runtime/bin/socket_impl.dart#ne...
runtime/bin/socket_impl.dart:422: if (_clientWriteHandler === null)
_writeHandler = null;
On 2011/12/23 08:35:40, Mads Ager wrote:
> Can't we just unconditionally do '_writeHandler = _clientWriteHandler' here?
No
> reason the keep checking for the first out event when we have just received
it?
> 
> Maybe we should even move that to the first line of writeHandler before the
> check on first out event. Once writeHandler has been called once there is no
> need to check for first out event again?

Good point. Refactored to only use this write handler for the first out event.
After that the write handler is always set to the _clientWriteHandler.

http://codereview.chromium.org/9029001/diff/1/tests/standalone/src/FileTest.dart
File tests/standalone/src/FileTest.dart (right):

http://codereview.chromium.org/9029001/diff/1/tests/standalone/src/FileTest.d...
tests/standalone/src/FileTest.dart:80: //input.close();
On 2011/12/23 08:35:40, Mads Ager wrote:
> Code in comment.

Done.