Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(6)

Unified Diff: tools/testing/dart/status_file_parser.dart

Issue 9029001: Add close to input stream and cleanup socket and streams (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Addressed comments by ager@ Created 8 years, 12 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « tests/stub-generator/test_config.dart ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/testing/dart/status_file_parser.dart
diff --git a/tools/testing/dart/status_file_parser.dart b/tools/testing/dart/status_file_parser.dart
index c29f9f584a4ff8f45f4330a9b52479ada8d1cbd6..ac53f89da57ab991c02b060d967bb67b355e7736 100644
--- a/tools/testing/dart/status_file_parser.dart
+++ b/tools/testing/dart/status_file_parser.dart
@@ -66,7 +66,7 @@ void ReadTestExpectationsInto(TestExpectations expectations,
void ReadConfigurationInto(path, sections, onDone) {
File file = new File(getFilename(path));
if (!file.existsSync()) return; // TODO(whesse): Handle missing file.
- FileInputStream file_stream = file.openInputStream();
+ InputStream file_stream = file.openInputStream();
StringInputStream lines = new StringInputStream(file_stream);
Section current = new Section.always();
@@ -114,7 +114,6 @@ void ReadConfigurationInto(path, sections, onDone) {
};
lines.closeHandler = () {
- file_stream.close();
onDone();
};
}
« no previous file with comments | « tests/stub-generator/test_config.dart ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698