Issue 9027017: - Promote objects from new gen to old space if they survived a scavenge.

Issue 9027017: - Promote objects from new gen to old space if they survived a scavenge. (Closed)

Created:
9 years ago by Ivan Posva

Modified:
9 years ago

Reviewers:
siva

CC:
reviews_dartlang.org, vm-dev_dartlang.org

Base URL:
http://dart.googlecode.com/svn/branches/bleeding_edge/dart/runtime/

Visibility:
Public.

More Reviews

Description

- Promote objects from new gen to old space if they survived a scavenge. - Properly initialize the tags in intrinsified allocation. - Check for valid tag bits. Committed: https://code.google.com/p/dart/source/detail?r=2796

Patch Set 1 #

Total comments: 6

Patch Set 2 : '' #

Created: 9 years ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+124 lines, -49 lines)			Patch
M	vm/heap.h	View		2 chunks	+15 lines, -2 lines	0 comments	Download
M	vm/intrinsifier_ia32.cc	View		1 chunk	+4 lines, -1 line	0 comments	Download
M	vm/object.cc	View		1 chunk	+1 line, -0 lines	0 comments	Download
M	vm/pages.h	View	1	1 chunk	+1 line, -1 line	0 comments	Download
M	vm/pages.cc	View	1	1 chunk	+2 lines, -1 line	0 comments	Download
M	vm/raw_object.h	View	1	2 chunks	+12 lines, -16 lines	0 comments	Download
M	vm/raw_object.cc	View		3 chunks	+5 lines, -17 lines	0 comments	Download
M	vm/scavenger.h	View	1	5 chunks	+30 lines, -1 line	0 comments	Download
M	vm/scavenger.cc	View		7 chunks	+54 lines, -10 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

siva

lgtm http://codereview.chromium.org/9027017/diff/1/vm/pages.h File vm/pages.h (right): http://codereview.chromium.org/9027017/diff/1/vm/pages.h#newcode106 vm/pages.h:106: bool CanIncreaseCapacity(intptr_t increase) { Why did you remove ...

9 years ago (2011-12-22 23:48:38 UTC) #2

Ivan Posva

9 years ago (2011-12-23 00:12:05 UTC) #3

http://codereview.chromium.org/9027017/diff/1/vm/pages.h
File vm/pages.h (right):

http://codereview.chromium.org/9027017/diff/1/vm/pages.h#newcode106
vm/pages.h:106: bool CanIncreaseCapacity(intptr_t increase) {
On 2011/12/22 23:48:38, asiva wrote:
> Why did you remove the assert why not change to:
> ASSERT(capacity_ <= max_capacity_);

Assertion adjusted.

http://codereview.chromium.org/9027017/diff/1/vm/raw_object.h
File vm/raw_object.h (right):

http://codereview.chromium.org/9027017/diff/1/vm/raw_object.h#newcode220
vm/raw_object.h:220: kMarkBit = 0,
On 2011/12/22 23:48:38, asiva wrote:
> Shouldn't this be 1?

Done.

http://codereview.chromium.org/9027017/diff/1/vm/scavenger.h
File vm/scavenger.h (right):

http://codereview.chromium.org/9027017/diff/1/vm/scavenger.h#newcode83
vm/scavenger.h:83: // This is implemented as a stack of objects at the end of
the to space. As
On 2011/12/22 23:48:38, asiva wrote:
> As object sizes are always greater than sizeof(uword) and promoted objects do
> not consume space

Done.

Expand Messages | Collapse Messages