Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(844)

Unified Diff: vm/raw_object.h

Issue 9027017: - Promote objects from new gen to old space if they survived a scavenge. (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/runtime/
Patch Set: '' Created 9 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « vm/pages.cc ('k') | vm/raw_object.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: vm/raw_object.h
===================================================================
--- vm/raw_object.h (revision 2792)
+++ vm/raw_object.h (working copy)
@@ -160,20 +160,17 @@
// Support for GC marking bit.
bool IsMarked() const {
- uword header_bits = reinterpret_cast<uword>(ptr()->class_);
- uword mark_bits = header_bits & kMarkingMask;
- ASSERT((mark_bits == kNotMarked) || (mark_bits == kMarked));
- return mark_bits == kMarked;
+ return MarkBit::decode(ptr()->tags_);
}
void SetMarkBit() {
ASSERT(!IsMarked());
- uword header_bits = reinterpret_cast<uword>(ptr()->class_);
- ptr()->class_ = reinterpret_cast<RawClass*>(header_bits | kMarked);
+ intptr_t tags = ptr()->tags_;
+ ptr()->tags_ = MarkBit::update(true, tags);
}
void ClearMarkBit() {
ASSERT(IsMarked());
- uword header_bits = reinterpret_cast<uword>(ptr()->class_);
- ptr()->class_ = reinterpret_cast<RawClass*>(header_bits ^ kMarkBit);
+ intptr_t tags = ptr()->tags_;
+ ptr()->tags_ = MarkBit::update(false, tags);
}
// Support for object tags.
@@ -220,18 +217,17 @@
private:
enum {
- kMarkingMask = 3,
- kNotMarked = 1, // Tagged pointer.
- kMarked = 3, // Tagged pointer and forwarding bit set.
- kMarkBit = 2,
+ kMarkBit = 1,
+ kCanonicalBit = 2,
+ kFromSnapshotBit = 3,
};
- class CanonicalObjectTag : public BitField<bool, 2, 1> {
- };
+ class MarkBit : public BitField<bool, kMarkBit, 1> {};
- class CreatedFromSnapshotTag : public BitField<bool, 3, 1> {
- };
+ class CanonicalObjectTag : public BitField<bool, kCanonicalBit, 1> {};
+ class CreatedFromSnapshotTag : public BitField<bool, kFromSnapshotBit, 1> {};
+
RawObject* ptr() const {
ASSERT(IsHeapObject());
return reinterpret_cast<RawObject*>(
« no previous file with comments | « vm/pages.cc ('k') | vm/raw_object.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698