Hacking format of Expect failure messages to play nice with rendered HTML.

Hacking format of Expect failure messages to play nice with rendered HTML.

The culprits are the '<' and '>' in this bit:

  _fail("Expect.equals(expected: <$expected>, actual: <$actual>$msg) fails.")

in Expect.equals(..) which cause $expected and $actual to get treated as tags when
the message is shoveled (untreated) into an HTML page as one might do when rendering
test run results in an HTML page (e.g., http://codereview.chromium.org/9034030/).

This here *hack* sidesteps the issue but it's neither elegant nor properly
placed (methinks).  The question is, how should this problem get fixed for real?
Thoughts/redirects greatly appreciated!
Committed: https://code.google.com/p/dart/source/detail?r=2954

[Siggi Cherem (dart-lang), 2012-01-04 16:28:36]

lgtm

This seems reasonable to me.

I'd add a TODO to move the escaping code to some common library (see that it is
already defined in utils/dartdoc/markdown.dart, samples/markdown/lib.dart, and
utils/tip/tip.dart.)

Or add a common library, which I'm not sure where it should go.

http://codereview.chromium.org/9022042/diff/5001/client/testing/unittest/unit...
File client/testing/unittest/unittest.dart (right):

http://codereview.chromium.org/9022042/diff/5001/client/testing/unittest/unit...
client/testing/unittest/unittest.dart:106: String _sanitize(String string) {
_sanitize -> _htmlEscape ?

http://codereview.chromium.org/9022042/diff/5001/client/testing/unittest/unit...
client/testing/unittest/unittest.dart:107: return
string.replaceAll('<','&lt;').replaceAll('>','&gt;');
add also '&amp;'

[pquitslund, 2012-01-04 18:05:50]

On 2012/01/04 16:28:36, sigmund wrote:
> lgtm
> 
> This seems reasonable to me.

Cool.  Thanks.

> 
> I'd add a TODO to move the escaping code to some common library (see that it
is
> already defined in utils/dartdoc/markdown.dart, samples/markdown/lib.dart, and
> utils/tip/tip.dart.)

Done.

> 
> Or add a common library, which I'm not sure where it should go.

A good idea I think but since I'm only just starting to feel my way around I'm
not ready to propose a home either...

> 
>
http://codereview.chromium.org/9022042/diff/5001/client/testing/unittest/unit...
> File client/testing/unittest/unittest.dart (right):
> 
>
http://codereview.chromium.org/9022042/diff/5001/client/testing/unittest/unit...
> client/testing/unittest/unittest.dart:106: String _sanitize(String string) {
> _sanitize -> _htmlEscape ?

Done.

> 
>
http://codereview.chromium.org/9022042/diff/5001/client/testing/unittest/unit...
> client/testing/unittest/unittest.dart:107: return
> string.replaceAll('<','&lt;').replaceAll('>','&gt;');
> add also '&amp;'

Right!  Fixed.

Thanks!